From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chris Bagwell <chris@cnpbagwell.com>
Cc: linux-input@vger.kernel.org, pinglinux@gmail.com, rydberg@euromail.se
Subject: Re: [PATCH v2] Input: wacom - fix touch on newer Bamboo's
Date: Mon, 12 Sep 2011 22:10:13 -0700 [thread overview]
Message-ID: <20110913051013.GA27416@core.coreip.homeip.net> (raw)
In-Reply-To: <CAGzDe_aqxwvv0Q0-SP8xsDOja6PdyWbTZKHFkn9vn_ihp47toA@mail.gmail.com>
On Sun, Sep 11, 2011 at 09:08:51PM -0500, Chris Bagwell wrote:
> On Fri, Sep 9, 2011 at 3:41 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Tue, Sep 06, 2011 at 06:56:46PM -0500, chris@cnpbagwell.com wrote:
> >> From: Chris Bagwell <chris@cnpbagwell.com>
> >>
> >> Bamboo's with Product ID's > 0xD4 return values unrelated to pressure
> >> in touch 1 pressure field. They also report touch 2's X/Y values
> >> shifted down 1 byte (where pressure was). This results in jumpy
> >> 1 finger touch and totally invalid 2nd finger data.
> >>
> >> For touch detection, switch to a Touch Present single bit that
> >> all versions of Bamboo support.
> >>
> >> For touch 2 offset, calculate offset based on a bit that is set
> >> different between the two packet layouts.
> >>
> >> Since touch pressure reports were removed from driver, there was
> >> no need to be reading pressure any more.
> >>
> >> Signed-off-by: Chris Bagwell <chris@cnpbagwell.com>
> >> Reviewed-by: Ping Cheng <pinglinux@gmail.com>
> >
> > Applied, thanks Chris.
> >
>
> I'm sorry, Dmitry, but I messed up this version #2 of patch. Can you
> please revert or hand fix?
>
> + touch = touch && wacom->shared->stylus_in_proximity;
>
> Somewhere along the line, I lost a "!" on that stylus_in_proximity
> check. So this v2 patch breaks touch support.
>
> If you revert, I am planning on submitting 2 or 3 new wacom clean up
> patches in next week. I can resend with that batch.
I just fixed it up locally, no need to resend.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-09-13 5:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 23:56 [PATCH v2] Input: wacom - fix touch on newer Bamboo's chris
2011-09-09 20:41 ` Dmitry Torokhov
2011-09-12 2:08 ` Chris Bagwell
2011-09-13 5:10 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110913051013.GA27416@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chris@cnpbagwell.com \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).