From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2] Input: wacom - fix touch on newer Bamboo's Date: Mon, 12 Sep 2011 22:10:13 -0700 Message-ID: <20110913051013.GA27416@core.coreip.homeip.net> References: <1315353406-8564-1-git-send-email-chris@cnpbagwell.com> <20110909204112.GB9157@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-yw0-f46.google.com ([209.85.213.46]:34422 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020Ab1IMFKU (ORCPT ); Tue, 13 Sep 2011 01:10:20 -0400 Received: by ywb5 with SMTP id 5so143368ywb.19 for ; Mon, 12 Sep 2011 22:10:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Chris Bagwell Cc: linux-input@vger.kernel.org, pinglinux@gmail.com, rydberg@euromail.se On Sun, Sep 11, 2011 at 09:08:51PM -0500, Chris Bagwell wrote: > On Fri, Sep 9, 2011 at 3:41 PM, Dmitry Torokhov > wrote: > > On Tue, Sep 06, 2011 at 06:56:46PM -0500, chris@cnpbagwell.com wrot= e: > >> From: Chris Bagwell > >> > >> Bamboo's with Product ID's > 0xD4 return values unrelated to press= ure > >> in touch 1 pressure field. =A0They also report touch 2's X/Y value= s > >> shifted down 1 byte (where pressure was). =A0This results in jumpy > >> 1 finger touch and totally invalid 2nd finger data. > >> > >> For touch detection, switch to a Touch Present single bit that > >> all versions of Bamboo support. > >> > >> For touch 2 offset, calculate offset based on a bit that is set > >> different between the two packet layouts. > >> > >> Since touch pressure reports were removed from driver, there was > >> no need to be reading pressure any more. > >> > >> Signed-off-by: Chris Bagwell > >> Reviewed-by: Ping Cheng > > > > Applied, thanks Chris. > > >=20 > I'm sorry, Dmitry, but I messed up this version #2 of patch. Can you > please revert or hand fix? >=20 > + touch =3D touch && wacom->shared->stylus_in_proximity= ; >=20 > Somewhere along the line, I lost a "!" on that stylus_in_proximity > check. So this v2 patch breaks touch support. >=20 > If you revert, I am planning on submitting 2 or 3 new wacom clean up > patches in next week. I can resend with that batch. I just fixed it up locally, no need to resend. Thanks. --=20 Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html