From: Marek Vasut <marek.vasut@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: "Benjamin Tissoires" <benjamin.tissoires@gmail.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, "Jiri Kosina" <jkosina@suse.cz>,
"Stéphane Chatty" <chatty@enac.fr>
Subject: Re: [PATCH] Input: HID-multitouch: Add egalax ID for Acer Iconia W500
Date: Fri, 16 Sep 2011 17:23:56 +0200 [thread overview]
Message-ID: <201109161723.56701.marek.vasut@gmail.com> (raw)
In-Reply-To: <20110916144700.GA5768@polaris.bitmath.org>
On Friday, September 16, 2011 04:47:00 PM Henrik Rydberg wrote:
> On Fri, Sep 16, 2011 at 03:07:44PM +0200, Marek Vasut wrote:
> > On Friday, September 16, 2011 11:48:56 AM Henrik Rydberg wrote:
> > > > Globally, the patch is clean. I don't really like it because a
> > > > cleaner way would be to just remove the field .maxcontacts in
> > > > MT_CLS_EGALAX. This would require tests from all the different
> > > > eGalax owners, and personally, I don't have the time to lead them.
> > >
> > > It is not too late to start now, though; testing this new device
> > > without maxcontacts would help when/if the ten-finger version comes
> > > along. Marek, would you care to try that?
> >
> > Well I own only this one particular device, not the other ones.
>
> I meant removing .maxcontacts from _your_ patch, and testing on your
> particular device.
Ah all right, yes, I can try it. But only _after_ my exam on wednesday (or
before in case I start being tired of learning).
You're welcome!
Cheers
>
> Thanks,
> Henrik
next prev parent reply other threads:[~2011-09-16 15:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 3:15 [PATCH] Input: HID-multitouch: Add egalax ID for Acer Iconia W500 Marek Vasut
2011-09-16 6:28 ` Dmitry Torokhov
2011-09-16 9:23 ` Benjamin Tissoires
2011-09-16 9:48 ` Henrik Rydberg
2011-09-16 13:07 ` Marek Vasut
2011-09-16 14:47 ` Henrik Rydberg
2011-09-16 15:23 ` Marek Vasut [this message]
2011-09-20 13:06 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2011-11-14 16:41 Marek Vasut
2011-11-14 19:08 ` Chase Douglas
2011-11-15 21:23 ` Chris Bagwell
2011-11-15 21:28 ` Marek Vasut
2011-11-15 21:44 ` Chris Bagwell
2011-11-15 22:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109161723.56701.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).