* [PATCH 0/6] mc13783 cleanup
@ 2011-08-24 13:27 Uwe Kleine-König
[not found] ` <1314192505-23499-1-git-send-email-u.kleine-koenig@pengutronix.de>
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Uwe Kleine-König @ 2011-08-24 13:27 UTC (permalink / raw)
To: Richard Purdie, Dmitry Torokhov, Samuel Ortiz, Sascha Hauer,
Jean Delvare
Cc: linux-arm-kernel, linux-kernel, kernel, lm-sensors, linux-input,
David Jander
Hello,
this series removes the long obsolte mc13783 API after fixing all
remaining users.
The patches touch many subsystems and have some interdependencies:
- patches 3 and 5 depend on patch 2
- patch 6 depends on patches 1-5
So we have to think about how to merge them when everyone is OK that
they are merged.
Best regards
Uwe
The following changes since commit 14c62e78dc1379185515be41903c4a667efc6d54:
Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip (2011-08-23 18:09:08 -0700)
are available in the git repository at:
git://git.pengutronix.de/git/ukl/linux-2.6.git mc13xxx
David Jander (1):
led/mc13783: convert to mc13xxx MFD
Uwe Kleine-König (5):
mfd/mc13xxx: provide a generic version of adc_do_conversion
input/mc13783-ts: convert to mc13xxx API
ARM: imx: use mc13xxx constants instead of mc13783
hwmon/mc13783-adc: convert to mc13xxx API
mfd/mc13xxx: remove mc13783 API functions and symbols
arch/arm/mach-imx/mach-mx27_3ds.c | 4 +-
arch/arm/mach-imx/mach-mx31_3ds.c | 2 +-
arch/arm/mach-imx/mach-pcm038.c | 4 +-
drivers/hwmon/mc13783-adc.c | 12 ++--
drivers/input/touchscreen/mc13783_ts.c | 34 +++++-----
drivers/leds/leds-mc13783.c | 52 ++++++++--------
drivers/mfd/mc13xxx-core.c | 97 ++++++++++++----------------
include/linux/mfd/mc13783.h | 111 --------------------------------
include/linux/mfd/mc13xxx.h | 19 ++++++
9 files changed, 115 insertions(+), 220 deletions(-)
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/6] mfd/mc13xxx: provide a generic version of adc_do_conversion
[not found] ` <1314192505-23499-1-git-send-email-u.kleine-koenig@pengutronix.de>
@ 2011-08-24 13:28 ` Uwe Kleine-König
2011-08-24 13:28 ` [PATCH 3/6] input/mc13783-ts: convert to mc13xxx API Uwe Kleine-König
1 sibling, 0 replies; 9+ messages in thread
From: Uwe Kleine-König @ 2011-08-24 13:28 UTC (permalink / raw)
To: Samuel Ortiz, Jean Delvare, Dmitry Torokhov
Cc: linux-kernel, kernel, lm-sensors, linux-input
This is needed to convert the touch driver away from using struct mc13783.
Note this patch drops MC13783_ADC0_ADREFMODE. This is unused and doesn't
exist on mc13892.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/mfd/mc13xxx-core.c | 89 +++++++++++++++++++++----------------------
include/linux/mfd/mc13783.h | 35 +++++++++--------
include/linux/mfd/mc13xxx.h | 19 +++++++++
3 files changed, 81 insertions(+), 62 deletions(-)
diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c
index 7e4d44b..5ee5e64 100644
--- a/drivers/mfd/mc13xxx-core.c
+++ b/drivers/mfd/mc13xxx-core.c
@@ -26,12 +26,12 @@ struct mc13xxx {
irq_handler_t irqhandler[MC13XXX_NUM_IRQ];
void *irqdata[MC13XXX_NUM_IRQ];
+
+ int adcflags;
};
struct mc13783 {
struct mc13xxx mc13xxx;
-
- int adcflags;
};
struct mc13xxx *mc13783_to_mc13xxx(struct mc13783 *mc13783)
@@ -136,14 +136,14 @@ EXPORT_SYMBOL(mc13783_to_mc13xxx);
#define MC13XXX_REVISION_FAB (0x03 << 11)
#define MC13XXX_REVISION_ICIDCODE (0x3f << 13)
-#define MC13783_ADC1 44
-#define MC13783_ADC1_ADEN (1 << 0)
-#define MC13783_ADC1_RAND (1 << 1)
-#define MC13783_ADC1_ADSEL (1 << 3)
-#define MC13783_ADC1_ASC (1 << 20)
-#define MC13783_ADC1_ADTRIGIGN (1 << 21)
+#define MC13XXX_ADC1 44
+#define MC13XXX_ADC1_ADEN (1 << 0)
+#define MC13XXX_ADC1_RAND (1 << 1)
+#define MC13XXX_ADC1_ADSEL (1 << 3)
+#define MC13XXX_ADC1_ASC (1 << 20)
+#define MC13XXX_ADC1_ADTRIGIGN (1 << 21)
-#define MC13783_ADC2 45
+#define MC13XXX_ADC2 45
#define MC13XXX_NUMREGS 0x3f
@@ -569,15 +569,15 @@ int mc13xxx_get_flags(struct mc13xxx *mc13xxx)
}
EXPORT_SYMBOL(mc13xxx_get_flags);
-#define MC13783_ADC1_CHAN0_SHIFT 5
-#define MC13783_ADC1_CHAN1_SHIFT 8
+#define MC13XXX_ADC1_CHAN0_SHIFT 5
+#define MC13XXX_ADC1_CHAN1_SHIFT 8
struct mc13xxx_adcdone_data {
struct mc13xxx *mc13xxx;
struct completion done;
};
-static irqreturn_t mc13783_handler_adcdone(int irq, void *data)
+static irqreturn_t mc13xxx_handler_adcdone(int irq, void *data)
{
struct mc13xxx_adcdone_data *adcdone_data = data;
@@ -588,12 +588,11 @@ static irqreturn_t mc13783_handler_adcdone(int irq, void *data)
return IRQ_HANDLED;
}
-#define MC13783_ADC_WORKING (1 << 0)
+#define MC13XXX_ADC_WORKING (1 << 0)
-int mc13783_adc_do_conversion(struct mc13783 *mc13783, unsigned int mode,
+int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode,
unsigned int channel, unsigned int *sample)
{
- struct mc13xxx *mc13xxx = &mc13783->mc13xxx;
u32 adc0, adc1, old_adc0;
int i, ret;
struct mc13xxx_adcdone_data adcdone_data = {
@@ -605,51 +604,51 @@ int mc13783_adc_do_conversion(struct mc13783 *mc13783, unsigned int mode,
mc13xxx_lock(mc13xxx);
- if (mc13783->adcflags & MC13783_ADC_WORKING) {
+ if (mc13xxx->adcflags & MC13XXX_ADC_WORKING) {
ret = -EBUSY;
goto out;
}
- mc13783->adcflags |= MC13783_ADC_WORKING;
+ mc13xxx->adcflags |= MC13XXX_ADC_WORKING;
- mc13xxx_reg_read(mc13xxx, MC13783_ADC0, &old_adc0);
+ mc13xxx_reg_read(mc13xxx, MC13XXX_ADC0, &old_adc0);
- adc0 = MC13783_ADC0_ADINC1 | MC13783_ADC0_ADINC2;
- adc1 = MC13783_ADC1_ADEN | MC13783_ADC1_ADTRIGIGN | MC13783_ADC1_ASC;
+ adc0 = MC13XXX_ADC0_ADINC1 | MC13XXX_ADC0_ADINC2;
+ adc1 = MC13XXX_ADC1_ADEN | MC13XXX_ADC1_ADTRIGIGN | MC13XXX_ADC1_ASC;
if (channel > 7)
- adc1 |= MC13783_ADC1_ADSEL;
+ adc1 |= MC13XXX_ADC1_ADSEL;
switch (mode) {
- case MC13783_ADC_MODE_TS:
- adc0 |= MC13783_ADC0_ADREFEN | MC13783_ADC0_TSMOD0 |
- MC13783_ADC0_TSMOD1;
- adc1 |= 4 << MC13783_ADC1_CHAN1_SHIFT;
+ case MC13XXX_ADC_MODE_TS:
+ adc0 |= MC13XXX_ADC0_ADREFEN | MC13XXX_ADC0_TSMOD0 |
+ MC13XXX_ADC0_TSMOD1;
+ adc1 |= 4 << MC13XXX_ADC1_CHAN1_SHIFT;
break;
- case MC13783_ADC_MODE_SINGLE_CHAN:
- adc0 |= old_adc0 & MC13783_ADC0_TSMOD_MASK;
- adc1 |= (channel & 0x7) << MC13783_ADC1_CHAN0_SHIFT;
- adc1 |= MC13783_ADC1_RAND;
+ case MC13XXX_ADC_MODE_SINGLE_CHAN:
+ adc0 |= old_adc0 & MC13XXX_ADC0_TSMOD_MASK;
+ adc1 |= (channel & 0x7) << MC13XXX_ADC1_CHAN0_SHIFT;
+ adc1 |= MC13XXX_ADC1_RAND;
break;
- case MC13783_ADC_MODE_MULT_CHAN:
- adc0 |= old_adc0 & MC13783_ADC0_TSMOD_MASK;
- adc1 |= 4 << MC13783_ADC1_CHAN1_SHIFT;
+ case MC13XXX_ADC_MODE_MULT_CHAN:
+ adc0 |= old_adc0 & MC13XXX_ADC0_TSMOD_MASK;
+ adc1 |= 4 << MC13XXX_ADC1_CHAN1_SHIFT;
break;
default:
- mc13783_unlock(mc13783);
+ mc13xxx_unlock(mc13xxx);
return -EINVAL;
}
- dev_dbg(&mc13783->mc13xxx.spidev->dev, "%s: request irq\n", __func__);
- mc13xxx_irq_request(mc13xxx, MC13783_IRQ_ADCDONE,
- mc13783_handler_adcdone, __func__, &adcdone_data);
- mc13xxx_irq_ack(mc13xxx, MC13783_IRQ_ADCDONE);
+ dev_dbg(&mc13xxx->spidev->dev, "%s: request irq\n", __func__);
+ mc13xxx_irq_request(mc13xxx, MC13XXX_IRQ_ADCDONE,
+ mc13xxx_handler_adcdone, __func__, &adcdone_data);
+ mc13xxx_irq_ack(mc13xxx, MC13XXX_IRQ_ADCDONE);
- mc13xxx_reg_write(mc13xxx, MC13783_ADC0, adc0);
- mc13xxx_reg_write(mc13xxx, MC13783_ADC1, adc1);
+ mc13xxx_reg_write(mc13xxx, MC13XXX_ADC0, adc0);
+ mc13xxx_reg_write(mc13xxx, MC13XXX_ADC1, adc1);
mc13xxx_unlock(mc13xxx);
@@ -660,27 +659,27 @@ int mc13783_adc_do_conversion(struct mc13783 *mc13783, unsigned int mode,
mc13xxx_lock(mc13xxx);
- mc13xxx_irq_free(mc13xxx, MC13783_IRQ_ADCDONE, &adcdone_data);
+ mc13xxx_irq_free(mc13xxx, MC13XXX_IRQ_ADCDONE, &adcdone_data);
if (ret > 0)
for (i = 0; i < 4; ++i) {
ret = mc13xxx_reg_read(mc13xxx,
- MC13783_ADC2, &sample[i]);
+ MC13XXX_ADC2, &sample[i]);
if (ret)
break;
}
- if (mode == MC13783_ADC_MODE_TS)
+ if (mode == MC13XXX_ADC_MODE_TS)
/* restore TSMOD */
- mc13xxx_reg_write(mc13xxx, MC13783_ADC0, old_adc0);
+ mc13xxx_reg_write(mc13xxx, MC13XXX_ADC0, old_adc0);
- mc13783->adcflags &= ~MC13783_ADC_WORKING;
+ mc13xxx->adcflags &= ~MC13XXX_ADC_WORKING;
out:
mc13xxx_unlock(mc13xxx);
return ret;
}
-EXPORT_SYMBOL_GPL(mc13783_adc_do_conversion);
+EXPORT_SYMBOL_GPL(mc13xxx_adc_do_conversion);
static int mc13xxx_add_subdevice_pdata(struct mc13xxx *mc13xxx,
const char *format, void *pdata, size_t pdata_size)
diff --git a/include/linux/mfd/mc13783.h b/include/linux/mfd/mc13783.h
index 7d0f3d6..e7a3c01 100644
--- a/include/linux/mfd/mc13783.h
+++ b/include/linux/mfd/mc13783.h
@@ -89,18 +89,15 @@ static inline int mc13783_irq_ack(struct mc13783 *mc13783, int irq)
return mc13xxx_irq_ack(mc13783_to_mc13xxx(mc13783), irq);
}
-#define MC13783_ADC0 43
-#define MC13783_ADC0_ADREFEN (1 << 10)
-#define MC13783_ADC0_ADREFMODE (1 << 11)
-#define MC13783_ADC0_TSMOD0 (1 << 12)
-#define MC13783_ADC0_TSMOD1 (1 << 13)
-#define MC13783_ADC0_TSMOD2 (1 << 14)
-#define MC13783_ADC0_ADINC1 (1 << 16)
-#define MC13783_ADC0_ADINC2 (1 << 17)
-
-#define MC13783_ADC0_TSMOD_MASK (MC13783_ADC0_TSMOD0 | \
- MC13783_ADC0_TSMOD1 | \
- MC13783_ADC0_TSMOD2)
+#define MC13783_ADC0 MC13XXX_ADC0
+#define MC13783_ADC0_ADREFEN MC13XXX_ADC0_ADREFEN
+#define MC13783_ADC0_TSMOD0 MC13XXX_ADC0_TSMOD0
+#define MC13783_ADC0_TSMOD1 MC13XXX_ADC0_TSMOD1
+#define MC13783_ADC0_TSMOD2 MC13XXX_ADC0_TSMOD2
+#define MC13783_ADC0_ADINC1 MC13XXX_ADC0_ADINC1
+#define MC13783_ADC0_ADINC2 MC13XXX_ADC0_ADINC2
+
+#define MC13783_ADC0_TSMOD_MASK MC13XXX_ADC0_TSMOD_MASK
#define mc13783_regulator_init_data mc13xxx_regulator_init_data
#define mc13783_regulator_platform_data mc13xxx_regulator_platform_data
@@ -115,12 +112,16 @@ static inline int mc13783_irq_ack(struct mc13783 *mc13783, int irq)
#define MC13783_USE_REGULATOR MC13XXX_USE_REGULATOR
#define MC13783_USE_LED MC13XXX_USE_LED
-#define MC13783_ADC_MODE_TS 1
-#define MC13783_ADC_MODE_SINGLE_CHAN 2
-#define MC13783_ADC_MODE_MULT_CHAN 3
+#define MC13783_ADC_MODE_TS MC13XXX_ADC_MODE_TS
+#define MC13783_ADC_MODE_SINGLE_CHAN MC13XXX_ADC_MODE_SINGLE_CHAN
+#define MC13783_ADC_MODE_MULT_CHAN MC13XXX_ADC_MODE_MULT_CHAN
-int mc13783_adc_do_conversion(struct mc13783 *mc13783, unsigned int mode,
- unsigned int channel, unsigned int *sample);
+static inline int mc13783_adc_do_conversion(struct mc13783 *mc13783,
+ unsigned int mode, unsigned int channel, unsigned int *sample)
+{
+ return mc13xxx_adc_do_conversion(mc13783_to_mc13xxx(mc13783), mode,
+ channel, sample);
+}
#define MC13783_REG_SW1A 0
diff --git a/include/linux/mfd/mc13xxx.h b/include/linux/mfd/mc13xxx.h
index c064bea..6e7c0ac 100644
--- a/include/linux/mfd/mc13xxx.h
+++ b/include/linux/mfd/mc13xxx.h
@@ -37,6 +37,9 @@ int mc13xxx_irq_ack(struct mc13xxx *mc13xxx, int irq);
int mc13xxx_get_flags(struct mc13xxx *mc13xxx);
+int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx,
+ unsigned int mode, unsigned int channel, unsigned int *sample);
+
#define MC13XXX_IRQ_ADCDONE 0
#define MC13XXX_IRQ_ADCBISDONE 1
#define MC13XXX_IRQ_TS 2
@@ -150,4 +153,20 @@ struct mc13xxx_platform_data {
struct mc13xxx_leds_platform_data *leds;
};
+#define MC13XXX_ADC_MODE_TS 1
+#define MC13XXX_ADC_MODE_SINGLE_CHAN 2
+#define MC13XXX_ADC_MODE_MULT_CHAN 3
+
+#define MC13XXX_ADC0 43
+#define MC13XXX_ADC0_ADREFEN (1 << 10)
+#define MC13XXX_ADC0_TSMOD0 (1 << 12)
+#define MC13XXX_ADC0_TSMOD1 (1 << 13)
+#define MC13XXX_ADC0_TSMOD2 (1 << 14)
+#define MC13XXX_ADC0_ADINC1 (1 << 16)
+#define MC13XXX_ADC0_ADINC2 (1 << 17)
+
+#define MC13XXX_ADC0_TSMOD_MASK (MC13XXX_ADC0_TSMOD0 | \
+ MC13XXX_ADC0_TSMOD1 | \
+ MC13XXX_ADC0_TSMOD2)
+
#endif /* ifndef __LINUX_MFD_MC13XXX_H */
--
1.7.5.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/6] input/mc13783-ts: convert to mc13xxx API
[not found] ` <1314192505-23499-1-git-send-email-u.kleine-koenig@pengutronix.de>
2011-08-24 13:28 ` [PATCH 2/6] mfd/mc13xxx: provide a generic version of adc_do_conversion Uwe Kleine-König
@ 2011-08-24 13:28 ` Uwe Kleine-König
1 sibling, 0 replies; 9+ messages in thread
From: Uwe Kleine-König @ 2011-08-24 13:28 UTC (permalink / raw)
To: Samuel Ortiz, Dmitry Torokhov; +Cc: linux-kernel, kernel, linux-input
This is the first step to also support the touch interface of the mc13892
pmic chip.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/input/touchscreen/mc13783_ts.c | 34 ++++++++++++++++----------------
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/input/touchscreen/mc13783_ts.c b/drivers/input/touchscreen/mc13783_ts.c
index c5bc62d..ede0274 100644
--- a/drivers/input/touchscreen/mc13783_ts.c
+++ b/drivers/input/touchscreen/mc13783_ts.c
@@ -35,7 +35,7 @@ MODULE_PARM_DESC(sample_tolerance,
struct mc13783_ts_priv {
struct input_dev *idev;
- struct mc13783 *mc13783;
+ struct mc13xxx *mc13xxx;
struct delayed_work work;
struct workqueue_struct *workq;
unsigned int sample[4];
@@ -45,7 +45,7 @@ static irqreturn_t mc13783_ts_handler(int irq, void *data)
{
struct mc13783_ts_priv *priv = data;
- mc13783_irq_ack(priv->mc13783, irq);
+ mc13xxx_irq_ack(priv->mc13xxx, irq);
/*
* Kick off reading coordinates. Note that if work happens already
@@ -121,10 +121,10 @@ static void mc13783_ts_work(struct work_struct *work)
{
struct mc13783_ts_priv *priv =
container_of(work, struct mc13783_ts_priv, work.work);
- unsigned int mode = MC13783_ADC_MODE_TS;
+ unsigned int mode = MC13XXX_ADC_MODE_TS;
unsigned int channel = 12;
- if (mc13783_adc_do_conversion(priv->mc13783,
+ if (mc13xxx_adc_do_conversion(priv->mc13xxx,
mode, channel, priv->sample) == 0)
mc13783_ts_report_sample(priv);
}
@@ -134,21 +134,21 @@ static int mc13783_ts_open(struct input_dev *dev)
struct mc13783_ts_priv *priv = input_get_drvdata(dev);
int ret;
- mc13783_lock(priv->mc13783);
+ mc13xxx_lock(priv->mc13xxx);
- mc13783_irq_ack(priv->mc13783, MC13783_IRQ_TS);
+ mc13xxx_irq_ack(priv->mc13xxx, MC13XXX_IRQ_TS);
- ret = mc13783_irq_request(priv->mc13783, MC13783_IRQ_TS,
+ ret = mc13xxx_irq_request(priv->mc13xxx, MC13XXX_IRQ_TS,
mc13783_ts_handler, MC13783_TS_NAME, priv);
if (ret)
goto out;
- ret = mc13783_reg_rmw(priv->mc13783, MC13783_ADC0,
- MC13783_ADC0_TSMOD_MASK, MC13783_ADC0_TSMOD0);
+ ret = mc13xxx_reg_rmw(priv->mc13xxx, MC13XXX_ADC0,
+ MC13XXX_ADC0_TSMOD_MASK, MC13XXX_ADC0_TSMOD0);
if (ret)
- mc13783_irq_free(priv->mc13783, MC13783_IRQ_TS, priv);
+ mc13xxx_irq_free(priv->mc13xxx, MC13XXX_IRQ_TS, priv);
out:
- mc13783_unlock(priv->mc13783);
+ mc13xxx_unlock(priv->mc13xxx);
return ret;
}
@@ -156,11 +156,11 @@ static void mc13783_ts_close(struct input_dev *dev)
{
struct mc13783_ts_priv *priv = input_get_drvdata(dev);
- mc13783_lock(priv->mc13783);
- mc13783_reg_rmw(priv->mc13783, MC13783_ADC0,
- MC13783_ADC0_TSMOD_MASK, 0);
- mc13783_irq_free(priv->mc13783, MC13783_IRQ_TS, priv);
- mc13783_unlock(priv->mc13783);
+ mc13xxx_lock(priv->mc13xxx);
+ mc13xxx_reg_rmw(priv->mc13xxx, MC13XXX_ADC0,
+ MC13XXX_ADC0_TSMOD_MASK, 0);
+ mc13xxx_irq_free(priv->mc13xxx, MC13XXX_IRQ_TS, priv);
+ mc13xxx_unlock(priv->mc13xxx);
cancel_delayed_work_sync(&priv->work);
}
@@ -177,7 +177,7 @@ static int __init mc13783_ts_probe(struct platform_device *pdev)
goto err_free_mem;
INIT_DELAYED_WORK(&priv->work, mc13783_ts_work);
- priv->mc13783 = dev_get_drvdata(pdev->dev.parent);
+ priv->mc13xxx = dev_get_drvdata(pdev->dev.parent);
priv->idev = idev;
/*
--
1.7.5.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 0/6] mc13783 cleanup
2011-08-24 13:27 [PATCH 0/6] mc13783 cleanup Uwe Kleine-König
[not found] ` <1314192505-23499-1-git-send-email-u.kleine-koenig@pengutronix.de>
@ 2011-08-25 7:05 ` Philippe Rétornaz
2011-08-25 7:57 ` Uwe Kleine-König
2011-09-15 15:12 ` Samuel Ortiz
2011-09-15 15:10 ` Samuel Ortiz
2 siblings, 2 replies; 9+ messages in thread
From: Philippe Rétornaz @ 2011-08-25 7:05 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Uwe Kleine-König, Richard Purdie, Dmitry Torokhov,
Samuel Ortiz, Sascha Hauer, Jean Delvare, David Jander,
linux-kernel, lm-sensors, kernel, linux-input
Le mercredi 24 août 2011 15:27:40, Uwe Kleine-König a écrit :
> Hello,
>
> this series removes the long obsolte mc13783 API after fixing all
> remaining users.
I posted a patch last month which was touching this MFD too.
We will need to synchronize both patch.
BTW, Sascha, could you give your ack/nack on my patch (mc13783: add pwr button
support) ? it has been a month without any news from your side. Thanks !
Regards,
Philippe
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/6] mc13783 cleanup
2011-08-25 7:05 ` [PATCH 0/6] mc13783 cleanup Philippe Rétornaz
@ 2011-08-25 7:57 ` Uwe Kleine-König
2011-09-15 15:12 ` Samuel Ortiz
1 sibling, 0 replies; 9+ messages in thread
From: Uwe Kleine-König @ 2011-08-25 7:57 UTC (permalink / raw)
To: Philippe Rétornaz
Cc: linux-arm-kernel, linux-input, Samuel Ortiz, Sascha Hauer,
Dmitry Torokhov, David Jander, linux-kernel, lm-sensors,
Richard Purdie, kernel, Jean Delvare
On Thu, Aug 25, 2011 at 09:05:12AM +0200, Philippe Rétornaz wrote:
> Le mercredi 24 août 2011 15:27:40, Uwe Kleine-König a écrit :
> > Hello,
> >
> > this series removes the long obsolte mc13783 API after fixing all
> > remaining users.
>
> I posted a patch last month which was touching this MFD too.
> We will need to synchronize both patch.
Ah right. At one point I remembered your patch set because I wondered
that ..._USE_REGULATOR is still used.
Assuming all involved people are OK with both patch sets I can do the
merge of both patch sets.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/6] mc13783 cleanup
2011-08-24 13:27 [PATCH 0/6] mc13783 cleanup Uwe Kleine-König
[not found] ` <1314192505-23499-1-git-send-email-u.kleine-koenig@pengutronix.de>
2011-08-25 7:05 ` [PATCH 0/6] mc13783 cleanup Philippe Rétornaz
@ 2011-09-15 15:10 ` Samuel Ortiz
2 siblings, 0 replies; 9+ messages in thread
From: Samuel Ortiz @ 2011-09-15 15:10 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Richard Purdie, Dmitry Torokhov, Sascha Hauer, Jean Delvare,
linux-arm-kernel, linux-kernel, kernel, lm-sensors, linux-input,
David Jander
Hi Uwe,
On Wed, Aug 24, 2011 at 03:27:40PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> this series removes the long obsolte mc13783 API after fixing all
> remaining users.
>
> The patches touch many subsystems and have some interdependencies:
>
> - patches 3 and 5 depend on patch 2
> - patch 6 depends on patches 1-5
>
> So we have to think about how to merge them when everyone is OK that
> they are merged.
I am merging them, unless someone objects here.
I have applied all 6 patches now.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/6] mc13783 cleanup
2011-08-25 7:05 ` [PATCH 0/6] mc13783 cleanup Philippe Rétornaz
2011-08-25 7:57 ` Uwe Kleine-König
@ 2011-09-15 15:12 ` Samuel Ortiz
2011-09-15 16:03 ` Uwe Kleine-König
1 sibling, 1 reply; 9+ messages in thread
From: Samuel Ortiz @ 2011-09-15 15:12 UTC (permalink / raw)
To: Philippe Rétornaz
Cc: linux-arm-kernel, Uwe Kleine-König, Richard Purdie,
Dmitry Torokhov, Sascha Hauer, Jean Delvare, David Jander,
linux-kernel, lm-sensors, kernel, linux-input
Hi Philippe,
On Thu, Aug 25, 2011 at 09:05:12AM +0200, Philippe Rétornaz wrote:
> Le mercredi 24 août 2011 15:27:40, Uwe Kleine-König a écrit :
> > Hello,
> >
> > this series removes the long obsolte mc13783 API after fixing all
> > remaining users.
>
> I posted a patch last month which was touching this MFD too.
> We will need to synchronize both patch.
I applied Uwe's patchset now. Could you please sync your code and send me a
patchset that applies on top of:
git://git.infradead.org/users/sameo/mfd-2.6.git for-next
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/6] mc13783 cleanup
2011-09-15 15:12 ` Samuel Ortiz
@ 2011-09-15 16:03 ` Uwe Kleine-König
2011-09-18 16:33 ` Samuel Ortiz
0 siblings, 1 reply; 9+ messages in thread
From: Uwe Kleine-König @ 2011-09-15 16:03 UTC (permalink / raw)
To: Samuel Ortiz
Cc: linux-input, Sascha Hauer, Dmitry Torokhov, linux-kernel,
lm-sensors, Richard Purdie, kernel, David Jander, Jean Delvare,
Philippe Rétornaz, linux-arm-kernel
Hi Samuel,
On Thu, Sep 15, 2011 at 05:12:13PM +0200, Samuel Ortiz wrote:
> On Thu, Aug 25, 2011 at 09:05:12AM +0200, Philippe Rétornaz wrote:
> > Le mercredi 24 août 2011 15:27:40, Uwe Kleine-König a écrit :
> > > Hello,
> > >
> > > this series removes the long obsolte mc13783 API after fixing all
> > > remaining users.
> >
> > I posted a patch last month which was touching this MFD too.
> > We will need to synchronize both patch.
> I applied Uwe's patchset now.
Thanks.
> Could you please sync your code and send me a
> patchset that applies on top of:
>
> git://git.infradead.org/users/sameo/mfd-2.6.git for-next
You can fetch the updated series from
git://git.pengutronix.de/git/ukl/linux-2.6.git mc13783
I also included the last patch that Sascha commented with:
Please ping once the rest is merged.
This is OK as I'm currently substituting Sascha for imx maintainer
duties while he is on vacation. Merging the above branch into the
current imx/for-next branch yields a merge conflict in
drivers/rtc/rtc-twl.c which is only touched on your side and in Linus'
tree below imx/for-next.
I guess you can drop 54d96ef785b5 as it is the same as dec35d19c4 +
34d623d.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/6] mc13783 cleanup
2011-09-15 16:03 ` Uwe Kleine-König
@ 2011-09-18 16:33 ` Samuel Ortiz
0 siblings, 0 replies; 9+ messages in thread
From: Samuel Ortiz @ 2011-09-18 16:33 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Philippe Rétornaz, linux-arm-kernel, Richard Purdie,
Dmitry Torokhov, Sascha Hauer, Jean Delvare, David Jander,
linux-kernel, lm-sensors, kernel, linux-input
Hi Uwe,
On Thu, Sep 15, 2011 at 06:03:21PM +0200, Uwe Kleine-König wrote:
> Hi Samuel,
>
> On Thu, Sep 15, 2011 at 05:12:13PM +0200, Samuel Ortiz wrote:
> > On Thu, Aug 25, 2011 at 09:05:12AM +0200, Philippe Rétornaz wrote:
> > > Le mercredi 24 août 2011 15:27:40, Uwe Kleine-König a écrit :
> > > > Hello,
> > > >
> > > > this series removes the long obsolte mc13783 API after fixing all
> > > > remaining users.
> > >
> > > I posted a patch last month which was touching this MFD too.
> > > We will need to synchronize both patch.
> > I applied Uwe's patchset now.
> Thanks.
>
> > Could you please sync your code and send me a
> > patchset that applies on top of:
> >
> > git://git.infradead.org/users/sameo/mfd-2.6.git for-next
> You can fetch the updated series from
>
> git://git.pengutronix.de/git/ukl/linux-2.6.git mc13783
I merged this one on top of my for-next branch. My MFD tree temporary lives on
infradead:
git://git.infradead.org/users/sameo/mfd-2.6.git
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-09-18 16:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-24 13:27 [PATCH 0/6] mc13783 cleanup Uwe Kleine-König
[not found] ` <1314192505-23499-1-git-send-email-u.kleine-koenig@pengutronix.de>
2011-08-24 13:28 ` [PATCH 2/6] mfd/mc13xxx: provide a generic version of adc_do_conversion Uwe Kleine-König
2011-08-24 13:28 ` [PATCH 3/6] input/mc13783-ts: convert to mc13xxx API Uwe Kleine-König
2011-08-25 7:05 ` [PATCH 0/6] mc13783 cleanup Philippe Rétornaz
2011-08-25 7:57 ` Uwe Kleine-König
2011-09-15 15:12 ` Samuel Ortiz
2011-09-15 16:03 ` Uwe Kleine-König
2011-09-18 16:33 ` Samuel Ortiz
2011-09-15 15:10 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).