linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Oliver Neukum <oliver@neukum.org>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] input: Fix USB autosuspend on bcm5974
Date: Fri, 7 Oct 2011 19:06:12 +0200	[thread overview]
Message-ID: <20111007170612.GA2215@polaris.bitmath.org> (raw)
In-Reply-To: <20111007162756.GA12136@srcf.ucam.org>

On Fri, Oct 07, 2011 at 05:27:56PM +0100, Matthew Garrett wrote:
> On Fri, Oct 07, 2011 at 09:20:27AM -0700, Dmitry Torokhov wrote:
> > On Fri, Oct 07, 2011 at 01:36:53PM +0100, Matthew Garrett wrote:
> > > On Fri, Oct 07, 2011 at 08:37:46AM +0200, Oliver Neukum wrote:
> > > 
> > > > Please also note that for a device to generate wakeup events the kernel has to
> > > > enable them which drivers have to request, like the usbhid driver does.
> > > > If you do this you better have a test device, because I found that most
> > > > generic mice generate wakeup events only if you press a button, not move
> > > > the mouse. We are simply not equipped in our API to use that capability.
> > > 
> > > This hardware generates wakeups events on touch.
> > 
> > Is it true for all generations that the driver supports?
> 
> As far as I can tell.

And yet, there is a complication, since the keyboard and mouse
interfaces are both present on the same device. I just ran a small
test, on an MBA3,1. While it is true that the trackpad generates
wakeup events on touch, it enters a loop of suspend/resume, presumably
due to the keyboard. Moreover, the trackpad emits some strange packets
which leave a (large) message trail.

Henrik

  reply	other threads:[~2011-10-07 16:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-06 21:36 [PATCH] input: Fix USB autosuspend on bcm5974 Matthew Garrett
2011-10-06 22:38 ` Dmitry Torokhov
2011-10-06 23:19   ` Matthew Garrett
2011-10-07  6:37     ` Oliver Neukum
2011-10-07 12:36       ` Matthew Garrett
2011-10-07 16:20         ` Dmitry Torokhov
2011-10-07 16:27           ` Matthew Garrett
2011-10-07 17:06             ` Henrik Rydberg [this message]
2011-10-07 17:13               ` Matthew Garrett
2011-10-07 17:42                 ` Henrik Rydberg
2011-10-07 17:39                   ` Matthew Garrett
2011-10-07 18:13                     ` Henrik Rydberg
2011-10-07 19:20                       ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111007170612.GA2215@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).