From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Oliver Neukum <oneukum@suse.de>
Cc: linux-input@vger.kernel.org, rydberg@euromail.se, dtor@mail.ru
Subject: Re: [PATCH V2] input: Fix USB autosuspend on bcm5974
Date: Mon, 10 Oct 2011 15:38:02 +0100 [thread overview]
Message-ID: <20111010143802.GA18364@srcf.ucam.org> (raw)
In-Reply-To: <201110101634.39018.oneukum@suse.de>
On Mon, Oct 10, 2011 at 04:34:38PM +0200, Oliver Neukum wrote:
> Am Montag, 10. Oktober 2011, 16:16:35 schrieb Matthew Garrett:
> > On Mon, Oct 10, 2011 at 04:06:37PM +0200, Oliver Neukum wrote:
> >
> > > This is odd, because the hardware shouldn't generate remote wakeups unless you
> > > request them, like this (usbhid)
> >
> > I thought needs_remote_wakeup was a hint to the kernel that remote
> > wakeup ability was required for the hardware to autosuspend? In theory I
>
> It fulfills that role, but it is not its sole function.
>
> > guess it should be set, but in practice all the hardware supported by
> > this driver generates them so it'd be a noop. No objection to adding it
> > in the name of correctness (or if some future version is broken, I
> > guess...), though.
>
> It is used in usb_port_suspend in form of do_remote_wakeup which
> is computed from it. And we send a real control message.
do_remote_wakeup will be set if device_may_wakeup is true, regardless of
whether the driver asks for it. Or am I misreading choose_wakeup()?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-10-10 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 13:41 [PATCH V2] input: Fix USB autosuspend on bcm5974 Matthew Garrett
2011-10-10 14:06 ` Oliver Neukum
2011-10-10 14:16 ` Matthew Garrett
2011-10-10 14:34 ` Oliver Neukum
2011-10-10 14:38 ` Matthew Garrett [this message]
2011-10-10 14:42 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010143802.GA18364@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=dtor@mail.ru \
--cc=linux-input@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).