From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Wanlong Gao <gaowanlong@cn.fujitsu.com>,
JJ Ding <jj_ding@emc.com.tw>,
linux-input@vger.kernel.org, JJ Ding <dgdunix@gmail.com>
Subject: Re: [PATCH] Input: psmouse - change log messages from psmouse.c to psmouse
Date: Mon, 10 Oct 2011 18:22:47 -0700 [thread overview]
Message-ID: <20111011012247.GB11832@core.coreip.homeip.net> (raw)
In-Reply-To: <CAGS+omACkwB1GSxcFHiuvi43Q5dzx_m-K_85VHOJSKc3YUXSnA@mail.gmail.com>
Hi Daniel,
On Fri, Oct 07, 2011 at 06:07:28PM +0800, Daniel Kurtz wrote:
> Hi Dmitry,
>
> On Fri, Oct 7, 2011 at 2:39 PM, Dmitry Torokhov
> >
> > -static int synaptics_validate_byte(unsigned char packet[], int idx, unsigned char pkt_type)
>
> Why pass idx if we already have psmouse?
>
> static int synaptics_validate_byte(struct psmouse *psmouse, unsigned
> char pkt_type)
We are checking specific byte... If you look down we call the function
in a cycle over entire packet to fugure whether we need to do strict or
relaxed checking.
...
> >
> > if (synaptics_query_hardware(psmouse)) {
> > - printk(KERN_ERR "Unable to query Synaptics hardware.\n");
> > + psmouse_err(psmouse, "Unable to query Synaptics hardware.\n");
> psmouse_err(psmouse, "unable to query device.\n");
>
> We can get rid of some more redundant "Synaptics"...
>
Good idea, I'll update the messages.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-10-11 1:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 5:14 [PATCH] Input: psmouse - change log messages from psmouse.c to psmouse JJ Ding
2011-09-29 5:17 ` Wanlong Gao
2011-10-07 6:39 ` Dmitry Torokhov
2011-10-07 8:15 ` Wanlong Gao
2011-10-07 9:30 ` JJ Ding
2011-10-07 10:07 ` Daniel Kurtz
2011-10-11 1:22 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011012247.GB11832@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dgdunix@gmail.com \
--cc=djkurtz@chromium.org \
--cc=gaowanlong@cn.fujitsu.com \
--cc=jj_ding@emc.com.tw \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).