From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
Samuel Ortiz <samuel.ortiz@intel.com>, Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Misael Lopez Cruz <misael.lopez@ti.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2 2/6] MFD: twl6040: Cache the vibra control registers
Date: Tue, 11 Oct 2011 09:01:42 -0700 [thread overview]
Message-ID: <20111011160142.GB10286@core.coreip.homeip.net> (raw)
In-Reply-To: <20111011144824.GE1098@sirena.org.uk>
On Tue, Oct 11, 2011 at 03:48:24PM +0100, Mark Brown wrote:
> On Fri, Sep 23, 2011 at 09:49:40AM +0300, Peter Ujfalusi wrote:
> > The vibra control register will be used from the ASoC codec driver as well.
> > In order to avoid latency issues caused by I2C read access, cache the two
> > control register within the core driver, so we do not need to reach out
> > to the chip to read it back.
> >
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> It strikes me that it might be useful to just convert the driver to
> regmap and get cache for everything...
>
> Anyway, could you please restructure this series to minimize the
> dependency on the input subsystem? Then we can get the rest of it
> applied.
>
I'm OK with all patches going through MFD - I do not believe it will
cause any merge issues.
For the record I still do not like returning EBUSY when device is not
available - I think if device can't serve any requests it should not
exists at all.
--
Dmitry
next prev parent reply other threads:[~2011-10-11 16:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 6:49 [PATCH v2 0/6] ASoC/MFD/Input: twl6040: Support for audio driven vibra Peter Ujfalusi
2011-09-23 6:49 ` [PATCH v2 1/6] Input: twl6040: Simplify vibra regsiter definitions Peter Ujfalusi
2011-09-23 6:49 ` [PATCH v2 2/6] MFD: twl6040: Cache the vibra control registers Peter Ujfalusi
2011-10-10 19:04 ` Samuel Ortiz
2011-10-11 14:48 ` Mark Brown
2011-10-11 16:01 ` Dmitry Torokhov [this message]
2011-10-12 8:05 ` Péter Ujfalusi
2011-10-12 7:53 ` Péter Ujfalusi
2011-09-23 6:49 ` [PATCH v2 3/6] MFD: twl6040: function to query the vibra status for clients Peter Ujfalusi
2011-10-10 19:05 ` Samuel Ortiz
2011-10-11 3:49 ` Ujfalusi, Peter
2011-09-23 6:49 ` [PATCH v2 4/6] Input: twl6040-vibra: Check the selected path for vibra Peter Ujfalusi
2011-09-23 6:49 ` [PATCH v2 5/6] ASoC: omap-mcpdm: Correct the supported number of channels Peter Ujfalusi
2011-09-23 10:52 ` Mark Brown
2011-09-23 6:49 ` [PATCH v2 6/6] ASoC: twl6040: Support for vibra output paths Peter Ujfalusi
2011-10-10 18:36 ` [PATCH v2 0/6] ASoC/MFD/Input: twl6040: Support for audio driven vibra Ujfalusi, Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011160142.GB10286@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=samuel.ortiz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).