From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Oliver Neukum <oliver@neukum.org>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Alan Stern <stern@rowland.harvard.edu>,
linux-input@vger.kernel.org, dtor@mail.ru
Subject: Re: [PATCH V3] input: Fix USB autosuspend on bcm5974
Date: Tue, 11 Oct 2011 21:42:50 +0100 [thread overview]
Message-ID: <20111011204250.GA14186@srcf.ucam.org> (raw)
In-Reply-To: <201110111309.21132.oliver@neukum.org>
On Tue, Oct 11, 2011 at 01:09:21PM +0200, Oliver Neukum wrote:
> Am Dienstag, 11. Oktober 2011, 13:04:21 schrieb Henrik Rydberg:
> > Problem: the hid keyboard driver refuses to suspend while a key is
> > pressed, which is fine per se, but there is no indication presented to the power layer,
> > resulting in a failed suspend and (due to complex reasons it seems) disabled autosuspend.
>
> That is a bug. Autosuspend at a later date should happen.
Yeah, there's definitely something broken here. If I hold down a key on
a USB keyboard for more than two seconds then it attempts to suspend but
fails. Releasing the key triggers another usb_mark_busy() but the core
never tries to suspend it again. What /does/ trigger a second attempt at
suspend is toggling an LED on and then off.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-10-11 20:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 15:47 [PATCH V3] input: Fix USB autosuspend on bcm5974 Matthew Garrett
2011-10-10 21:05 ` Henrik Rydberg
2011-10-10 21:12 ` Matthew Garrett
2011-10-10 22:44 ` Henrik Rydberg
2011-10-11 0:11 ` Matthew Garrett
2011-10-11 4:10 ` Oliver Neukum
2011-10-11 11:04 ` Henrik Rydberg
2011-10-11 11:09 ` Oliver Neukum
2011-10-11 20:42 ` Matthew Garrett [this message]
2011-10-12 6:32 ` Oliver Neukum
2011-10-12 14:33 ` Alan Stern
2011-10-12 14:37 ` Oliver Neukum
2011-10-12 15:28 ` Alan Stern
2011-10-12 16:16 ` Matthew Garrett
2011-10-12 16:56 ` Oliver Neukum
2011-10-12 16:59 ` Matthew Garrett
2011-10-12 17:24 ` Alan Stern
2011-10-12 17:26 ` Matthew Garrett
2011-10-12 17:41 ` Alan Stern
2011-10-12 18:33 ` Henrik Rydberg
2011-10-12 19:21 ` Alan Stern
2011-10-13 8:20 ` Henrik Rydberg
2011-10-13 15:49 ` Alan Stern
2011-10-13 17:21 ` Henrik Rydberg
2011-10-12 17:11 ` Oliver Neukum
2011-10-12 19:18 ` Alan Stern
2011-10-11 16:05 ` Dmitry Torokhov
2011-10-11 16:43 ` Alan Stern
2011-10-12 7:03 ` Oliver Neukum
2011-10-12 13:54 ` Matthew Garrett
2011-10-12 14:18 ` Alan Stern
2011-10-12 14:26 ` Matthew Garrett
2011-10-12 14:38 ` Oliver Neukum
2011-10-12 18:50 ` Henrik Rydberg
2011-10-13 6:47 ` Oliver Neukum
2011-10-10 21:16 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011204250.GA14186@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=dtor@mail.ru \
--cc=linux-input@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=rydberg@euromail.se \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).