From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: Hui Wang <jason77.wang@gmail.com>,
s.hauer@pengutronix.de, maramaopercheseimorto@gmail.com,
linux-input@vger.kernel.org
Subject: Re: [v2] input/imx_keypad: add pm suspend and resume functions
Date: Wed, 12 Oct 2011 21:13:29 -0700 [thread overview]
Message-ID: <20111013041328.GA11763@core.coreip.homeip.net> (raw)
In-Reply-To: <4E956271.3040002@cn.fujitsu.com>
On Wed, Oct 12, 2011 at 05:48:33PM +0800, Wanlong Gao wrote:
> On 10/12/2011 05:39 PM, Hui Wang wrote:
>
> > The imx_keypad driver is set wake capable in the imx_keypad_probe(),
> > but it doesn't implement suspend and reusme callback interface.
> >
> >>From the i.MX series MCU Reference Manual, the kpp (keypad port) is
> > a major wake up source which can detect any key press even in low
> > power modes and even when there is no clock.
> >
> > Now add suspend and resume callback functions for this driver.
> >
> > Signed-off-by: Hui Wang <jason77.wang@gmail.com>
>
>
> Looks good to me. Thanks
> Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Applied, thanks.
--
Dmitry
prev parent reply other threads:[~2011-10-13 4:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 9:39 [v2] input/imx_keypad: add pm suspend and resume functions Hui Wang
2011-10-12 9:48 ` Wanlong Gao
2011-10-13 4:13 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013041328.GA11763@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=jason77.wang@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=maramaopercheseimorto@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).