From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] Input: CMA3000 - signedness bug in cma3000_thread_irq() Date: Thu, 13 Oct 2011 09:42:57 +0300 Message-ID: <20111013064257.GA11651@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from acsinet15.oracle.com ([141.146.126.227]:51892 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287Ab1JMGnQ (ORCPT ); Thu, 13 Oct 2011 02:43:16 -0400 Content-Disposition: inline Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Paul Gortmaker , Shubhrajyoti , Sergio Aguirre , Jonathan Cameron , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org The ->read() function returns an int; negative error codes on error or a byte of data on success. intr_status needs to be signed here for the error handling to work. Signed-off-by: Dan Carpenter diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c index 80793f1..2a42b53 100644 --- a/drivers/input/misc/cma3000_d0x.c +++ b/drivers/input/misc/cma3000_d0x.c @@ -116,7 +116,8 @@ static irqreturn_t cma3000_thread_irq(int irq, void *dev_id) { struct cma3000_accl_data *data = dev_id; int datax, datay, dataz; - u8 ctrl, mode, range, intr_status; + u8 ctrl, mode, range; + int intr_status; intr_status = CMA3000_READ(data, CMA3000_INTSTATUS, "interrupt status"); if (intr_status < 0)