From: Oliver Neukum <oneukum@suse.de>
To: Benson Leung <bleung@chromium.org>
Cc: jkosina@suse.cz, stern@rowland.harvard.edu,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: usbhid: enable remote wakeup for mice
Date: Fri, 14 Oct 2011 10:18:28 +0200 [thread overview]
Message-ID: <201110141018.28446.oneukum@suse.de> (raw)
In-Reply-To: <1318578888-7599-1-git-send-email-bleung@chromium.org>
Am Freitag, 14. Oktober 2011, 09:54:48 schrieb Benson Leung:
> This patch enables remote wakeup by default on USB mouse
> devices. This only covers USB mice that support
> the boot protocol. See commit 3d61510f for the
> equivalent patch for USB keyboard devices.
This doesn't loo like a very good idea.
Firstly your patch introduces gratious change in the hid driver.
Secondly you are changing the usbmouse driver, which is to
be used under special circumstances only, only.
Thirdly a fundamental change like that needs a commit entry
explaining the reason for the change.
Regards
Oliver
next prev parent reply other threads:[~2011-10-14 8:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 7:54 [PATCH] HID: usbhid: enable remote wakeup for mice Benson Leung
2011-10-14 8:18 ` Oliver Neukum [this message]
2011-10-14 13:56 ` Alan Stern
2011-10-14 14:00 ` Jiri Kosina
2011-10-14 14:58 ` Benson Leung
2011-10-14 15:09 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1110141106270.2036-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2011-10-15 9:43 ` Oliver Neukum
2011-10-15 19:07 ` Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2023-02-22 1:39 Michael Wu
2023-02-22 6:04 ` Greg KH
2023-02-22 19:50 ` Limonciello, Mario
2023-02-23 11:41 ` Oliver Neukum
2023-02-23 11:18 ` Michael Wu
2023-02-23 11:23 ` Greg KH
2023-02-23 12:01 ` Oliver Neukum
2023-02-23 19:41 ` Limonciello, Mario
2023-02-28 9:03 ` Oliver Neukum
2023-02-28 18:50 ` Limonciello, Mario
2023-02-28 19:05 ` Greg KH
2023-02-28 19:07 ` Limonciello, Mario
2023-02-24 7:02 ` Michael Wu
2023-02-22 8:59 ` Sergei Shtylyov
2023-02-23 4:01 ` Michael Wu
2023-02-22 9:34 ` Oliver Neukum
2023-02-23 11:22 ` Michael Wu
2023-02-23 11:47 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110141018.28446.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=bleung@chromium.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).