From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: sameo@linux.intel.com, peter.ujfalusi@ti.com,
aghayal@codeaurora.org, david@hardeman.nu, Shubhrajyoti@ti.com,
saaguirre@ti.com, jic23@cam.ac.uk, hemanthv@ti.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 6/7] input/cma3000_d0x: Unwind reverse order of init
Date: Tue, 18 Oct 2011 10:03:46 -0700 [thread overview]
Message-ID: <201110181003.46805.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <CAPybu_16xkTK1dn_NKzduxb6Q=fESyi6d0mDswkDqUMOtoPfcg@mail.gmail.com>
On Tuesday, October 18, 2011 09:57:24 AM Ricardo Ribalda Delgado wrote:
> Hello Dmitry
>
> You are right, and also could be a good idea to init the irq, only
> after the input device has been registered. Dont you think so?
Input core is constructed in such way that it is safe to call
input_report_*() and input_event() on properly allocated input device,
even if it has not been registered yet, the events will simply be
dropped.
So no, it is not necessary and doing so is quite often complicates
error handling in probe() routines.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-10-18 17:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 15:47 [PATCHv3 0/7] Add spi support for CMA3000 driver and new driver CMR3000 Ricardo Ribalda Delgado
2011-10-18 15:48 ` [PATCHv3 1/7] input/cma3000_d0x: Support devices without pdata Ricardo Ribalda Delgado
2011-10-18 15:48 ` [PATCHv3 2/7] input/cma3000_d0x: Check silicon version Ricardo Ribalda Delgado
2011-10-18 15:48 ` [PATCHv3 3/7] input/cma3000_d0x: Keep configuration on poweroff Ricardo Ribalda Delgado
2011-10-18 15:48 ` [PATCHv3 4/7] input/cma3000_d0x: Add CMA3000 spi support Ricardo Ribalda Delgado
2011-10-18 15:48 ` [PATCHv3 5/7] Input: add CMR3000 gyrsocope driver Ricardo Ribalda Delgado
2011-10-18 15:48 ` [PATCHv3 6/7] input/cma3000_d0x: Unwind reverse order of init Ricardo Ribalda Delgado
2011-10-18 15:48 ` [PATCHv3 7/7] input/cma3000_d0x: Match comment to name of struct Ricardo Ribalda Delgado
[not found] ` <1318952886-835-2-git-send-email-ricardo.ribalda@gmail.com>
2011-10-18 15:59 ` [PATCHv3 1/7] input/cma3000_d0x: Support devices without pdata Jonathan Cameron
[not found] ` <1318952886-835-3-git-send-email-ricardo.ribalda@gmail.com>
2011-10-18 16:01 ` [PATCHv3 2/7] input/cma3000_d0x: Check silicon version Jonathan Cameron
[not found] ` <1318952886-835-5-git-send-email-ricardo.ribalda@gmail.com>
2011-10-18 16:02 ` [PATCHv3 4/7] input/cma3000_d0x: Add CMA3000 spi support Jonathan Cameron
[not found] ` <1318952886-835-7-git-send-email-ricardo.ribalda@gmail.com>
2011-10-18 16:53 ` [PATCHv3 6/7] input/cma3000_d0x: Unwind reverse order of init Dmitry Torokhov
2011-10-18 16:57 ` Ricardo Ribalda Delgado
2011-10-18 17:03 ` Dmitry Torokhov [this message]
2011-10-18 17:10 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110181003.46805.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=Shubhrajyoti@ti.com \
--cc=aghayal@codeaurora.org \
--cc=david@hardeman.nu \
--cc=hemanthv@ti.com \
--cc=jic23@cam.ac.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=ricardo.ribalda@gmail.com \
--cc=saaguirre@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).