From: Oliver Neukum <oneukum@suse.de>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-input@vger.kernel.org, jkosina@suse.cz
Subject: Re: [PATCH 04/16] HID: wiimote: Add extension support stub
Date: Mon, 14 Nov 2011 12:35:17 +0100 [thread overview]
Message-ID: <201111141235.17887.oneukum@suse.de> (raw)
In-Reply-To: <CANq1E4QbOHa=-Vqi5pmSDi5OHJhN6nXkxD1wcHUSi-2xnOagBw@mail.gmail.com>
Am Montag, 14. November 2011, 12:26:28 schrieb David Herrmann:
> I also know that wdata lives longer than wdata->ext so I cannot find
> any race condition here. I have checked all four entry points of the
> extension-module and they all seem fine here.
>
> As long as wdata->ext is non-NULL, wiiext_schedule may be called. So I
> first need to clear wdata->ext before I kill the worker. Otherwise the
> worker may be respawned before I reset wdata->ext ;)
Hi,
thank you for the detailed explanation. Could you include a comment
to explain the unusual order things are done in this function?
Regards
Oliver
next prev parent reply other threads:[~2011-11-14 11:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 13:27 [PATCH 00/16] Wiimote: Extension and Debug Support David Herrmann
2011-11-13 13:27 ` [PATCH 01/16] HID: wiimote: Rename driver to allow multiple source files David Herrmann
2011-11-13 13:27 ` [PATCH 02/16] HID: wiimote: Move common symbols into header David Herrmann
2011-11-13 13:27 ` [PATCH 03/16] HID: wiimote: Add read-mem helpers David Herrmann
2011-11-13 13:27 ` [PATCH 04/16] HID: wiimote: Add extension support stub David Herrmann
2011-11-14 7:54 ` Oliver Neukum
2011-11-14 11:26 ` David Herrmann
2011-11-14 11:35 ` Oliver Neukum [this message]
2011-11-15 19:24 ` David Herrmann
2011-11-13 13:27 ` [PATCH 05/16] HID: wiimote: Add extension initializer stubs David Herrmann
2011-11-13 13:27 ` [PATCH 06/16] HID: wiimote: Add extension initializers David Herrmann
2011-11-13 13:27 ` [PATCH 07/16] HID: wiimote: Add extension sysfs attribute David Herrmann
2011-11-13 13:27 ` [PATCH 08/16] HID: wiimote: Register input devices for extensions David Herrmann
2011-11-13 13:27 ` [PATCH 09/16] HID: wiimote: Add extension handler stubs David Herrmann
2011-11-13 13:27 ` [PATCH 10/16] HID: wiimote: Parse motion+ data David Herrmann
2011-11-13 13:27 ` [PATCH 11/16] HID: wiimote: Parse nunchuck data David Herrmann
2011-11-13 13:27 ` [PATCH 12/16] HID: wiimote: Parse classic controller data David Herrmann
2011-11-13 13:27 ` [PATCH 13/16] HID: wiimote: Add debugfs support stubs David Herrmann
2011-11-13 13:27 ` [PATCH 14/16] HID: wiimote: Allow direct eeprom access David Herrmann
2011-11-13 13:27 ` [PATCH 15/16] HID: wiimote: Allow direct DRM debug access David Herrmann
2011-11-13 13:27 ` [PATCH 16/16] HID: wiimote: Enable NO_INIT_REPORTS quirk David Herrmann
2011-11-16 17:05 ` Jiri Kosina
2011-11-16 17:49 ` David Herrmann
2011-11-16 18:39 ` Jiri Kosina
2011-11-17 13:11 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111141235.17887.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=dh.herrmann@googlemail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).