linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Kukjin Kim <kgene.kim@samsung.com>
Subject: Build breakage in samsung-keypad driver
Date: Tue, 15 Nov 2011 12:53:20 +0000	[thread overview]
Message-ID: <20111115125319.GF3077@opensource.wolfsonmicro.com> (raw)

Hi Dmitry,

Your commit 5862c02 (Input: samsung-keypad - enable compiling on other
platforms) breaks the build on any platform using the driver as you've
moved the header defining the platform data without updating any of the
users.  Whenever doing updates to platform data you really need to grep
the tree for users and make sure they're updated otherwise there will be
build breakage.

I also can't see the patch on the list...

Thanks,
Mark

             reply	other threads:[~2011-11-15 12:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15 12:53 Mark Brown [this message]
2011-11-15 17:21 ` Build breakage in samsung-keypad driver Dmitry Torokhov
2011-11-15 17:25   ` Mark Brown
2011-11-15 17:35     ` Dmitry Torokhov
2011-11-15 17:36       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111115125319.GF3077@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).