From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cedric Sodhi Subject: Re: HID: Dead ./debug/hid/xxx/events Date: Thu, 17 Nov 2011 07:59:55 +0100 Message-ID: <20111117065955.GB2110@slate> References: <20111116095030.GC3335@slate> <20111116102514.GA3831@slate> <20111116145518.GA7080@slate> <20111116154049.GA8444@slate> <4EC3EC63.4020700@gmail.com> <20111116204759.GA2153@slate> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout-de.gmx.net ([213.165.64.23]:55727 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751709Ab1KQHAP (ORCPT ); Thu, 17 Nov 2011 02:00:15 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Chris Bagwell Cc: Benjamin Tissoires , linux-input@vger.kernel.org, linuxwacom-devel@lists.sourceforge.net On Wed, Nov 16, 2011 at 03:23:50PM -0600, Chris Bagwell wrote: > One update on my side. I was looking at hid-multitouch.c from > Dmitri's next branch and didn't see that ALWAYS_VALID. So I thought > it was a typo and manually mapping your "18" value to > VALID_IS_INRANGE; which we were previously setting it to. Thats why = I > mentioned I thought you were setting to same quirks. >=20 > Thanks for diff. Often a diff is worth a thousand words. >=20 > OK, now back to your email. I'm confused about your logs. The URL > points to the tar file with multiple logs and the evtest_twofinger.lo= g > inside it is the one I was talking about having issues. Indeed. Those logs in the TAR file were created when I was still manually adding the device to sysfs (that is, before that very diff which includes changes to the whitelist). It looks like I neglected to set the quirks back then. Sorry. >=20 > Now you've attached a new evtest_twofinger.log and its values look > good. So your saying this new log is from a version based on the > diff? Exactly. Cedric > If so, I'll chalk it up to some debug issue and sounds like > ALWAYS_VALID is indeed the key to this. >=20 > Chris >=20 > On Wed, Nov 16, 2011 at 2:48 PM, Cedric Sodhi wrote: > > Dear Benjamin, > > > > I applied your patch tp 3.2-jikos (uname shows 3.1, though). The > > diff to jikos' original is now [attached]. > > > > Chris says the output of evtest still signifies problems with > > multitouch: > > > >> > http://ompldr.org/iYmIzYw > >> > >> Cedric, can you send these logs to Benjamin for ideas? =A0The HID = events > >> look good but the evtest log for 2 fingers is not. =A0The two touc= hes > >> are fighting each other. =A0That "-1" value is interrupted as each > >> finger is being lifted in between each new X/Y report. > >> > >> Also, can you send me and Benjamin the source code diff of what yo= ur > >> testing against kernel tree? > >> > >> The behavior in your evtest log looks like what would happen if yo= ur > >> setting the MT_QUIRK_NOT_SEEN_MEANS_UP. =A0Since your HW only send= s 1 > >> fingers worth of data per packet, you do not want that quirk. > >> > >> I'll still hold off on xf86-input-wacom issues until the events co= ming > >> are sane. =A0Your current events will cause xf86-input-wacom to do= all > >> kinds of weird stuff thats not worth effort to weed threw. > >> > >> Chris > > > > These logs in that tarfile were created while still manually adding= the > > ID via your sysfs interface. You find yet another evtest log for > > two-finger touch attached. > > > > Cedric > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input= " in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html