From: Anatolij Gustschin <agust@denx.de>
To: Ilya Yanok <yanok@emcraft.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, wd@denx.de, dzu@denx.de,
sasha_d@emcraft.com
Subject: Re: [PATCH] edt_ts: EDT Touchscreen driver
Date: Thu, 17 Nov 2011 13:20:41 +0100 [thread overview]
Message-ID: <20111117132041.0b581ac0@wker> (raw)
In-Reply-To: <4EC420A1.7080502@emcraft.com>
Hi Ilya,
On Thu, 17 Nov 2011 00:44:17 +0400
Ilya Yanok <yanok@emcraft.com> wrote:
> Hi Dmitry, Anatolij,
>
> On 15.11.2011 21:41, Dmitry Torokhov wrote:
> >>> Do you really need to read gpio state in IRQ? Can't you simply rely on
> >>> 'event' do decide whether to emit input events?
> >>
> >> We can't rely on the 'event' only. The peculiar behaviour of the
> >> touch controller enforces this. The touch controller toggles the
> >> interrupt line when you keep the finger down. The rate is not exactly
> >> specified by the the manufacturer (~80/sec). Measured rate deviates
> >> from this specified rate. Valid touch packet data can be read when
> >> interrupt line is pulled down.
> >
> > So what ensures that the gpio line stays low between the check and the
> > time you get access to i2c bus and get around reading the data.
>
> Anatolij, could you please comment on this? What can we do about this?
> Check the pin state after i2c read maybe?
I received a suggestion to look at the time elapsed since falling
edge of the GPIO IRQ before reading the touch packet data and
skip reading if it is too late. I'll also check what the touch
packet data looks like when reading it while finger is down but
the line stays high.
Anatolij
next prev parent reply other threads:[~2011-11-17 12:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 23:34 [PATCH] edt_ts: EDT Touchscreen driver Ilya Yanok
2011-11-14 17:28 ` Dmitry Torokhov
2011-11-14 21:07 ` Ilya Yanok
2011-11-14 21:32 ` Dmitry Torokhov
2011-11-15 9:17 ` Anatolij Gustschin
2011-11-15 9:30 ` Dmitry Torokhov
2011-11-15 17:41 ` Dmitry Torokhov
2011-11-16 20:44 ` Ilya Yanok
2011-11-17 12:20 ` Anatolij Gustschin [this message]
2011-11-20 18:09 ` Ilya Yanok
2011-11-20 18:36 ` Dmitry Torokhov
2011-11-20 19:22 ` Ilya Yanok
[not found] ` <CAM=Q2cuv_OFdrHpmf-fSRkiaz0X07vHpbpWH=MzfR_3S4OADjg@mail.gmail.com>
2011-11-21 9:24 ` Anatolij Gustschin
2011-11-30 9:34 ` Simon Budig
2011-12-14 23:49 ` Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117132041.0b581ac0@wker \
--to=agust@denx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=dzu@denx.de \
--cc=linux-input@vger.kernel.org \
--cc=sasha_d@emcraft.com \
--cc=wd@denx.de \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).