Re: [PATCH v2] HID: Add support for pressure sensitive buttons

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Tue, Nov 22, 2011 at 06:17:49PM +0100, Jiri Kosina wrote:
> On Tue, 22 Nov 2011, Sean Young wrote:
> 
> > > >I sent this almost a week ago. Any review comments please or is it
> > > >good for merging?
> > > >
> > > >Sean
> > > 
> > > Sorry for not replying earlier. To me patch looks ok. But I don't
> > > have working PS2 controller atm (well I have DDR-pad in storage, but
> > > I'm too lazy to move that monster around), so I can't really test
> > > this.
> > > 
> > > So I'd like to ask that would you like to take over maintaining of
> > > this driver? You seem to have access to more hardware anyway.
> > 
> > I do have four of the five usb controllers which the driver supports. I'd
> > be more than happy to maintain this driver, but I'm not sure I can do 
> > this while I'm not getting any other response on my patches.
> > 
> > Jiri, Dmitry: any review comments?
> 
> I'd like to at least get Dmitry's ack for the ff-memless change.

Actually I do not like it since it comingles unrelated parts: it is my
understanding that pressure-sensitive buttons should be able to work
ebven if user choses to disable force feedback support.

I also do not believe that the new attributes should reside with input
devices instead of HID device itself since they conrol aspects of the
work of real hardware, not input core abstraction.

Thanks.

-- 
Dmitry