Re: [PATCH v2] HID: Add support for pressure sensitive buttons

[Sean Young <sean@mess.org>]

On Tue, Nov 22, 2011 at 09:55:44AM -0800, Dmitry Torokhov wrote:
> On Tue, Nov 22, 2011 at 06:17:49PM +0100, Jiri Kosina wrote:
> > I'd like to at least get Dmitry's ack for the ff-memless change.
> 
> Actually I do not like it since it comingles unrelated parts: it is my
> understanding that pressure-sensitive buttons should be able to work
> ebven if user choses to disable force feedback support.

That's true. I do wonder why there is a separate config option for 
force feedback. It doesn't have a particularly large memory footprint.

> I also do not believe that the new attributes should reside with input
> devices instead of HID device itself since they conrol aspects of the
> work of real hardware, not input core abstraction.

Ok, I hadn't thought about it that way. Since these devices can up to 
four ports, we'll have controller_mode_port_{1,2,3,4} sysfs files, but I 
`guess there is no way around that.

Thank you for your review comments. I'll prepare a new patch.


Sean