Re: [PATCH] HID: bump maximum global item tag report size to 96 bytes

["Henrik Rydberg" <rydberg@euromail.se>]

On Mon, Nov 07, 2011 at 11:08:05AM -0800, Chase Douglas wrote:
> This allows the latest N-Trig devices to function properly.
> 
> BugLink: https://bugs.launchpad.net/bugs/724831
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
> ---
> I have no clue if this is according to spec or not. I only know that this
> change makes two users' N-Trig devices work properly in the above bug.
> 
>  drivers/hid/hid-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 848a56c..6113996 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -362,7 +362,7 @@ static int hid_parser_global(struct hid_parser *parser, struct hid_item *item)
>  
>  	case HID_GLOBAL_ITEM_TAG_REPORT_SIZE:
>  		parser->global.report_size = item_udata(item);
> -		if (parser->global.report_size > 32) {
> +		if (parser->global.report_size > 96) {
>  			dbg_hid("invalid report_size %d\n",
>  					parser->global.report_size);
>  			return -1;
> -- 
> 1.7.5.4

I remember writing this patch as a test, but I never checked the side
effects. Jiri, perhaps you can enlighten us all on this matter?

Thanks,
Henrik