From mboxrd@z Thu Jan  1 00:00:00 1970
From: Feng Tang <feng.tang@intel.com>
Subject: Re: [PATCH 2/2] Input: tsc2007 - Add a z1_low_threshhold platform
 data parameter
Date: Thu, 1 Dec 2011 17:04:55 +0800
Message-ID: <20111201170455.2e8ebcfc@feng-i7>
References: <1322554378-348-1-git-send-email-feng.tang@intel.com>
	<1322554378-348-2-git-send-email-feng.tang@intel.com>
	<20111129092310.GB21758@core.coreip.homeip.net>
	<20111130103418.4514b630@feng-i7>
	<20111201054726.GC16816@core.coreip.homeip.net>
	<20111201141948.13162071@feng-i7>
	<20111201084524.GB31610@core.coreip.homeip.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <linux-input-owner@vger.kernel.org>
Received: from mga09.intel.com ([134.134.136.24]:51560 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751307Ab1LAJFX (ORCPT <rfc822;linux-input@vger.kernel.org>);
	Thu, 1 Dec 2011 04:05:23 -0500
In-Reply-To: <20111201084524.GB31610@core.coreip.homeip.net>
Sender: linux-input-owner@vger.kernel.org
List-Id: linux-input@vger.kernel.org
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Clark, Joel" <joel.clark@intel.com>

Hi Dmitry,


On Thu, 1 Dec 2011 16:45:24 +0800
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:


> > > 
> > > Even if we add the pressure threshold would not that noise cause
> > > endless stream of interrupts?
> > 
> > No, there is no endless interrupts for tsc2007. Without the z1
> > threshold, the while circle in tsc2007_soft_irq will run endlessly
> > as the noise data will be seen as a valid data:
> > 
> > 		rt = tsc2007_calculate_pressure(ts, &tc);
> > 		if (rt == 0 && !ts->get_pendown_state) {
> > 			/*
> > 			 * If pressure reported is 0 and we don't
> > have
> > 			 * callback to check pendown state, we have
> > to
> > 			 * assume that pen was lifted up.
> > 			 */
> > 			break;
> > 		}
> > 
> > With the z1 threshold check, the rt will be 0 for noise data, and
> > the code flow broke out.
> 
> What I meant is with the threshold check we'll break out of the ISR
> but why won't IRQ be raised again?

The IRQ will be fired again after we exist the tsc2007_soft_irq in my
test, as I re-enable the irq before existing the code.

> 
> > 
> > > 
> > > Also, what kind of z2 is reported with low z1? And do you
> > > implement get_pendown_state()?
> > 
> > z2 seems normal as some data between 3000-4000. We don't have a
> > get_pendown_state().
> 
> OK, there is max_rt platform parameter. I think we should employ it
> instead and break out if we get several incorrect samples in a row.
> Too bad you do not have a dedicate method.
> 
No, the max_rt won't help here, if the rt > max_rt, it won't break the
while loop, but just issue a warning message

		if (rt <= ts->max_rt) {
			.......

		} else {
			/*
			 * Sample found inconsistent by debouncing or pressure is
			 * beyond the maximum. Don't report it to user space,
			 * repeat at least once more the measurement.
			 */
			dev_dbg(&ts->client->dev, "ignored pressure %d\n", rt);
		}

Thanks,
Feng