From: Anatolij Gustschin <agust@denx.de>
To: Simon Budig <simon.budig@kernelconcepts.de>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v2] Touchscreen driver for FT5x06 based EDT displays
Date: Fri, 2 Dec 2011 14:51:46 +0100 [thread overview]
Message-ID: <20111202145146.33d5b8be@wker> (raw)
In-Reply-To: <1317311577-29742-2-git-send-email-simon.budig@kernelconcepts.de>
Hi Simon,
there is a number of issues with this patch. Please check it
using 'scripts/checkpatch.pl' and fix them before posting next
patch version. Thanks! Please see a comment below.
On Thu, 29 Sep 2011 17:52:57 +0200
Simon Budig <simon.budig@kernelconcepts.de> wrote:
...
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> new file mode 100644
> index 0000000..1c4725d
> --- /dev/null
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
...
> +static int edt_ft5x06_i2c_ts_probe(struct i2c_client *client,
> + const struct i2c_device_id *id)
> +{
...
> +
> + dev_set_drvdata(&client->dev, tsdata);
> + tsdata->client = client;
> + pdata = client->dev.platform_data;
> +
> + tsdata->reset_pin = pdata->reset_pin;
passing platform data for specifying reset_pin should be optional,
I think. There are hardware configurations without wired gpio for
/RST controlling, /RST is controlled by HW-circuitry. The driver
should be usable with such configurations, too. Can you please
change the driver so that controlling reset pin becomes optional?
Thanks,
Anatolij
next prev parent reply other threads:[~2011-12-02 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 15:52 [PATCH v2] Touchscreen driver for FT5x06 based EDT displays Simon Budig
2011-09-29 15:52 ` Simon Budig
2011-12-02 13:51 ` Anatolij Gustschin [this message]
2011-12-15 11:00 ` Simon Budig
2011-12-15 12:17 ` agust
2011-12-15 13:41 ` Simon Budig
2011-12-16 11:51 ` Anatolij Gustschin
2011-12-20 22:47 ` Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111202145146.33d5b8be@wker \
--to=agust@denx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=simon.budig@kernelconcepts.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).