From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [GIT PULL] power_supply: add power supply scope Date: Thu, 8 Dec 2011 14:02:24 +0400 Message-ID: <20111208100204.GA31434@oksana.dev.rtsoft.ru> References: <4ED90E6D.8090402@goop.org> <4ED9BDF8.3010600@goop.org> <4EDE4C7A.1010802@goop.org> <4EDFA192.7000602@goop.org> <4EE015D1.5070005@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:38302 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904Ab1LHKCa (ORCPT ); Thu, 8 Dec 2011 05:02:30 -0500 Content-Disposition: inline In-Reply-To: <4EE015D1.5070005@goop.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jeremy Fitzhardinge Cc: David Woodhouse , Linux Kernel Mailing List , Richard Hughes , Daniel Nicoletti , linux-input@vger.kernel.org, Jiri Kosina , vojtech@ucw.cz, Przemo Firszt , Richard Hughes Hello Jeremy, On Wed, Dec 07, 2011 at 05:41:37PM -0800, Jeremy Fitzhardinge wrote: > This series adds a "scope" property to power supplies, so that a power > supply can indicate whether it powers the whole system, or just a > device. This allows upowerd to distinguish between actual system power > supplies, and self-powered devices such as wireless mice. I see one problem with this approach. Userland will need patching to distinguish system and device power supplies. So, even with the patch applied, old userland will behave incorrectly. So, instead of the new 'scope' property, how about adding another power supply type? I.e. DEVICE_BATTERY ? That type would be unknown to the current userland, and thus should be ignored. Thanks, -- Anton Vorontsov Email: cbouatmailru@gmail.com