* [PATCH 2/2] Input: keyboard: Staticise non-exported symbols
[not found] <1323394677.3740.2.camel@phoenix>
@ 2011-12-09 1:39 ` Axel Lin
2011-12-09 8:16 ` Michael Hennerich
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Axel Lin @ 2011-12-09 1:39 UTC (permalink / raw)
To: linux-kernel
Cc: Michael Hennerich, Naveen Kumar G, Sundar Iyer, Dmitry Torokhov,
linux-input
These symbols are not used outside it's driver so no need to
make the symbol global.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/input/keyboard/bf54x-keys.c | 2 +-
drivers/input/keyboard/nomadik-ske-keypad.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/bf54x-keys.c b/drivers/input/keyboard/bf54x-keys.c
index 683e314..8eb9116 100644
--- a/drivers/input/keyboard/bf54x-keys.c
+++ b/drivers/input/keyboard/bf54x-keys.c
@@ -384,7 +384,7 @@ static int bfin_kpad_resume(struct platform_device *pdev)
# define bfin_kpad_resume NULL
#endif
-struct platform_driver bfin_kpad_device_driver = {
+static struct platform_driver bfin_kpad_device_driver = {
.driver = {
.name = DRV_NAME,
.owner = THIS_MODULE,
diff --git a/drivers/input/keyboard/nomadik-ske-keypad.c b/drivers/input/keyboard/nomadik-ske-keypad.c
index 6c4828f..5a71e55 100644
--- a/drivers/input/keyboard/nomadik-ske-keypad.c
+++ b/drivers/input/keyboard/nomadik-ske-keypad.c
@@ -379,7 +379,7 @@ static const struct dev_pm_ops ske_keypad_dev_pm_ops = {
};
#endif
-struct platform_driver ske_keypad_driver = {
+static struct platform_driver ske_keypad_driver = {
.driver = {
.name = "nmk-ske-keypad",
.owner = THIS_MODULE,
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Input: keyboard: Staticise non-exported symbols
2011-12-09 1:39 ` [PATCH 2/2] Input: keyboard: Staticise non-exported symbols Axel Lin
@ 2011-12-09 8:16 ` Michael Hennerich
2011-12-09 12:01 ` Linus Walleij
2011-12-12 7:45 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Michael Hennerich @ 2011-12-09 8:16 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel@vger.kernel.org, Michael Hennerich, Naveen Kumar G,
Sundar Iyer, Dmitry Torokhov, linux-input@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org
On 12/09/2011 02:39 AM, Axel Lin wrote:
> These symbols are not used outside it's driver so no need to
> make the symbol global.
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/input/keyboard/bf54x-keys.c | 2 +-
> drivers/input/keyboard/nomadik-ske-keypad.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/bf54x-keys.c b/drivers/input/keyboard/bf54x-keys.c
> index 683e314..8eb9116 100644
> --- a/drivers/input/keyboard/bf54x-keys.c
> +++ b/drivers/input/keyboard/bf54x-keys.c
> @@ -384,7 +384,7 @@ static int bfin_kpad_resume(struct platform_device *pdev)
> # define bfin_kpad_resume NULL
> #endif
>
> -struct platform_driver bfin_kpad_device_driver = {
> +static struct platform_driver bfin_kpad_device_driver = {
> .driver = {
> .name = DRV_NAME,
> .owner = THIS_MODULE,
> diff --git a/drivers/input/keyboard/nomadik-ske-keypad.c b/drivers/input/keyboard/nomadik-ske-keypad.c
> index 6c4828f..5a71e55 100644
> --- a/drivers/input/keyboard/nomadik-ske-keypad.c
> +++ b/drivers/input/keyboard/nomadik-ske-keypad.c
> @@ -379,7 +379,7 @@ static const struct dev_pm_ops ske_keypad_dev_pm_ops = {
> };
> #endif
>
> -struct platform_driver ske_keypad_driver = {
> +static struct platform_driver ske_keypad_driver = {
> .driver = {
> .name = "nmk-ske-keypad",
> .owner = THIS_MODULE,
--
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Input: keyboard: Staticise non-exported symbols
2011-12-09 1:39 ` [PATCH 2/2] Input: keyboard: Staticise non-exported symbols Axel Lin
2011-12-09 8:16 ` Michael Hennerich
@ 2011-12-09 12:01 ` Linus Walleij
2011-12-12 7:45 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2011-12-09 12:01 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Michael Hennerich, Naveen Kumar G, Sundar Iyer,
Dmitry Torokhov, linux-input
On Fri, Dec 9, 2011 at 2:39 AM, Axel Lin <axel.lin@gmail.com> wrote:
> These symbols are not used outside it's driver so no need to
> make the symbol global.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
For SKE.
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Input: keyboard: Staticise non-exported symbols
2011-12-09 1:39 ` [PATCH 2/2] Input: keyboard: Staticise non-exported symbols Axel Lin
2011-12-09 8:16 ` Michael Hennerich
2011-12-09 12:01 ` Linus Walleij
@ 2011-12-12 7:45 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2011-12-12 7:45 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Michael Hennerich, Naveen Kumar G, Sundar Iyer,
linux-input
On Fri, Dec 09, 2011 at 09:39:12AM +0800, Axel Lin wrote:
> These symbols are not used outside it's driver so no need to
> make the symbol global.
>
Applied, thank you Axel.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-12 7:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1323394677.3740.2.camel@phoenix>
2011-12-09 1:39 ` [PATCH 2/2] Input: keyboard: Staticise non-exported symbols Axel Lin
2011-12-09 8:16 ` Michael Hennerich
2011-12-09 12:01 ` Linus Walleij
2011-12-12 7:45 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).