From: Oliver Neukum <oneukum@suse.de>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH] Input: bcm5974 - Fix USB autosuspend
Date: Mon, 12 Dec 2011 10:02:52 +0100 [thread overview]
Message-ID: <201112121002.53004.oneukum@suse.de> (raw)
In-Reply-To: <1323680764-2155-1-git-send-email-rydberg@euromail.se>
Am Montag, 12. Dezember 2011, 10:06:04 schrieb Henrik Rydberg:
> @@ -895,6 +857,10 @@ static int bcm5974_probe(struct usb_interface *iface,
> /* save our data pointer in this interface device */
> usb_set_intfdata(iface, dev);
>
> + error = bcm5974_start_traffic(dev);
> + if (error)
> + goto err_free_buffer;
> +
> return 0;
>
> err_free_buffer:
> --
Why do you want to start traffic before open() in probe() ?
It doesn't make sense to ask a device to deliver data nobody
wants.
Regards
Oliver
next prev parent reply other threads:[~2011-12-12 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 9:06 [PATCH] Input: bcm5974 - Fix USB autosuspend Henrik Rydberg
2011-12-12 9:02 ` Oliver Neukum [this message]
2011-12-12 10:26 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112121002.53004.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).