From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Xi Wang <xi.wang@gmail.com>
Cc: Valdis.Kletnieks@vt.edu,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: signedness bug in cma3000_thread_irq()
Date: Thu, 22 Dec 2011 09:50:20 -0800 [thread overview]
Message-ID: <20111222175020.GC21103@core.coreip.homeip.net> (raw)
In-Reply-To: <F920F5EE-FA61-4FFC-948C-97D6834823B6@gmail.com>
On Thu, Dec 15, 2011 at 05:17:02PM -0500, Xi Wang wrote:
> On Dec 14, 2011, at 10:21 PM, Valdis.Kletnieks@vt.edu wrote:
> > No, the variable that used to be a u8 - was it 8 bits wide for a reason?
>
> The return value of CMA3000_READ? I don't see any particular reason.
>
The data returned by CMA3000_READ() is a byte, so that's the reason (and
I am guessing here) that the author used u8 to store the result,
forgetting that the range was extended to report error conditions.
--
Dmitry
prev parent reply other threads:[~2011-12-22 17:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 6:49 [PATCH] input: signedness bug in cma3000_thread_irq() Xi Wang
2011-12-12 7:42 ` Dmitry Torokhov
2011-12-15 2:27 ` Valdis.Kletnieks
2011-12-15 2:35 ` Xi Wang
2011-12-15 3:21 ` Valdis.Kletnieks
2011-12-15 22:17 ` Xi Wang
2011-12-22 17:50 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111222175020.GC21103@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).