From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 2/3] input: mpu3050: Configure the sampling method
Date: Sat, 24 Dec 2011 00:07:52 -0800 [thread overview]
Message-ID: <20111224080752.GA13020@core.coreip.homeip.net> (raw)
In-Reply-To: <20111215221845.8657.17958.stgit@bob.linux.org.uk>
Hi Alan,
On Thu, Dec 15, 2011 at 10:18:47PM +0000, Alan Cox wrote:
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>
> This will improve the output of the sensor.
>
...
>
> +/* Configures the sampling method */
> +static int mpu3050_hw_init(struct mpu3050_sensor *sensor)
This should be __devinit.
...
> @@ -336,6 +423,10 @@ static int __devinit mpu3050_probe(struct i2c_client *client,
>
> pm_runtime_set_active(&client->dev);
>
> + error = mpu3050_hw_init(sensor);
> + if (error)
> + goto err_free_mem;
We should go to err_pm_set_suspended, not err_free_mem.
I fixed it up locally.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-12-24 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 22:18 [PATCH 0/3] mpu3050 updates Alan Cox
2011-12-15 22:18 ` [PATCH 1/3] input: mpu3050: Support for polled input device Alan Cox
2011-12-16 10:52 ` Shubhrajyoti
2011-12-28 5:07 ` Dmitry Torokhov
2011-12-15 22:18 ` [PATCH 2/3] input: mpu3050: Configure the sampling method Alan Cox
2011-12-24 8:07 ` Dmitry Torokhov [this message]
2011-12-15 22:18 ` [PATCH 3/3] input: mpu3050: Ensure we enable interrupts Alan Cox
2011-12-24 8:09 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111224080752.GA13020@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).