* [PATCH 1/1] hid_wiimote: add INPUT_FF_MEMLESS dependency
@ 2011-12-24 16:42 Alec Moskvin
2011-12-25 10:06 ` David Herrmann
0 siblings, 1 reply; 4+ messages in thread
From: Alec Moskvin @ 2011-12-24 16:42 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-input, linux-kernel, Alec Moskvin
This fixes build error:
...
CRC 17a7c33e
Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 7 modules
ERROR: "input_ff_create_memless" [drivers/hid/hid-wiimote.ko]
undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Signed-off-by: Alec Moskvin <alecmn@gmail.com>
---
drivers/hid/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 22a4a05..332c22a 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -620,6 +620,7 @@ config HID_WIIMOTE
depends on BT_HIDP
depends on LEDS_CLASS
select POWER_SUPPLY
+ select INPUT_FF_MEMLESS
---help---
Support for the Nintendo Wii Remote bluetooth device.
--
1.7.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] hid_wiimote: add INPUT_FF_MEMLESS dependency
2011-12-24 16:42 [PATCH 1/1] hid_wiimote: add INPUT_FF_MEMLESS dependency Alec Moskvin
@ 2011-12-25 10:06 ` David Herrmann
2011-12-25 16:13 ` Alec Moskvin
0 siblings, 1 reply; 4+ messages in thread
From: David Herrmann @ 2011-12-25 10:06 UTC (permalink / raw)
To: Alec Moskvin; +Cc: Jiri Kosina, linux-input, linux-kernel
Hi Alec
On Sat, Dec 24, 2011 at 5:42 PM, Alec Moskvin <alecmn@gmail.com> wrote:
> This fixes build error:
> ...
> CRC 17a7c33e
> Kernel: arch/x86/boot/bzImage is ready (#1)
> Building modules, stage 2.
> MODPOST 7 modules
> ERROR: "input_ff_create_memless" [drivers/hid/hid-wiimote.ko]
> undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> Signed-off-by: Alec Moskvin <alecmn@gmail.com>
> ---
> drivers/hid/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 22a4a05..332c22a 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -620,6 +620,7 @@ config HID_WIIMOTE
> depends on BT_HIDP
> depends on LEDS_CLASS
> select POWER_SUPPLY
> + select INPUT_FF_MEMLESS
> ---help---
> Support for the Nintendo Wii Remote bluetooth device.
>
This fix is already in Jiri's tree. See here:
http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;h=ef6f41157f3864d9bf42671b2ed66062dcafb72e
Regards
David
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] hid_wiimote: add INPUT_FF_MEMLESS dependency
2011-12-25 10:06 ` David Herrmann
@ 2011-12-25 16:13 ` Alec Moskvin
2011-12-26 10:04 ` David Herrmann
0 siblings, 1 reply; 4+ messages in thread
From: Alec Moskvin @ 2011-12-25 16:13 UTC (permalink / raw)
To: David Herrmann; +Cc: Jiri Kosina, linux-input, linux-kernel
Hi David,
On Sunday 25 December 2011 11:06:58, David Herrmann wrote:
> Hi Alec
>
> On Sat, Dec 24, 2011 at 5:42 PM, Alec Moskvin <alecmn@gmail.com> wrote:
> > This fixes build error:
> > ...
> > CRC 17a7c33e
> > Kernel: arch/x86/boot/bzImage is ready (#1)
> > Building modules, stage 2.
> > MODPOST 7 modules
> > ERROR: "input_ff_create_memless" [drivers/hid/hid-wiimote.ko]
> > undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> >
> > Signed-off-by: Alec Moskvin <alecmn@gmail.com>
> > ---
> > drivers/hid/Kconfig | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> > index 22a4a05..332c22a 100644
> > --- a/drivers/hid/Kconfig
> > +++ b/drivers/hid/Kconfig
> > @@ -620,6 +620,7 @@ config HID_WIIMOTE
> > depends on BT_HIDP
> > depends on LEDS_CLASS
> > select POWER_SUPPLY
> > + select INPUT_FF_MEMLESS
> > ---help---
> > Support for the Nintendo Wii Remote bluetooth device.
> >
>
> This fix is already in Jiri's tree. See here:
> http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;h=ef6f41157f3864d9bf42671b2ed66062dcafb72e
>
> Regards
> David
I wasn't aware of that. Shouldn't it be pushed to the main tree, then?
It's not in 3.2-rc7 (released yesterday), which is why I reported it.
Thanks,
Alec
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] hid_wiimote: add INPUT_FF_MEMLESS dependency
2011-12-25 16:13 ` Alec Moskvin
@ 2011-12-26 10:04 ` David Herrmann
0 siblings, 0 replies; 4+ messages in thread
From: David Herrmann @ 2011-12-26 10:04 UTC (permalink / raw)
To: Alec Moskvin; +Cc: Jiri Kosina, linux-input, linux-kernel
On Sun, Dec 25, 2011 at 5:13 PM, Alec Moskvin <alecmn@gmail.com> wrote:
> Hi David,
>
> On Sunday 25 December 2011 11:06:58, David Herrmann wrote:
>> Hi Alec
>>
>> On Sat, Dec 24, 2011 at 5:42 PM, Alec Moskvin <alecmn@gmail.com> wrote:
>> > This fixes build error:
>> > ...
>> > CRC 17a7c33e
>> > Kernel: arch/x86/boot/bzImage is ready (#1)
>> > Building modules, stage 2.
>> > MODPOST 7 modules
>> > ERROR: "input_ff_create_memless" [drivers/hid/hid-wiimote.ko]
>> > undefined!
>> > make[1]: *** [__modpost] Error 1
>> > make: *** [modules] Error 2
>> >
>> > Signed-off-by: Alec Moskvin <alecmn@gmail.com>
>> > ---
>> > drivers/hid/Kconfig | 1 +
>> > 1 files changed, 1 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
>> > index 22a4a05..332c22a 100644
>> > --- a/drivers/hid/Kconfig
>> > +++ b/drivers/hid/Kconfig
>> > @@ -620,6 +620,7 @@ config HID_WIIMOTE
>> > depends on BT_HIDP
>> > depends on LEDS_CLASS
>> > select POWER_SUPPLY
>> > + select INPUT_FF_MEMLESS
>> > ---help---
>> > Support for the Nintendo Wii Remote bluetooth device.
>> >
>>
>> This fix is already in Jiri's tree. See here:
>> http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;h=ef6f41157f3864d9bf42671b2ed66062dcafb72e
>>
>> Regards
>> David
>
> I wasn't aware of that. Shouldn't it be pushed to the main tree, then?
It's CC'ed to stable. I think Jiri will push it to linus soon. But
during Christmas some stuff may get lost so ping him if he missed
something ;)
> It's not in 3.2-rc7 (released yesterday), which is why I reported it.
>
> Thanks,
> Alec
Cheers
David
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-26 10:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-24 16:42 [PATCH 1/1] hid_wiimote: add INPUT_FF_MEMLESS dependency Alec Moskvin
2011-12-25 10:06 ` David Herrmann
2011-12-25 16:13 ` Alec Moskvin
2011-12-26 10:04 ` David Herrmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).