From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: John Stultz <john.stultz@linaro.org>
Cc: linux-input@vger.kernel.org, "Daniel Kurtz" <djkurtz@google.com>,
"Arve Hjønnevåg" <arve@android.com>
Subject: Re: [RFC][PATCH] Input: Add infrastrucutre for monotonic event time stamps.
Date: Thu, 5 Jan 2012 15:28:53 -0800 [thread overview]
Message-ID: <20120105232853.GA1193@core.coreip.homeip.net> (raw)
In-Reply-To: <1325804465-20612-1-git-send-email-john.stultz@linaro.org>
Hi John,
On Thu, Jan 05, 2012 at 03:01:05PM -0800, John Stultz wrote:
>
> + case EVIOCMONTIME:
> + if (copy_from_user(&i, p, sizeof(unsigned int)))
> + return -EFAULT;
> + client->use_monotonic = i;
> + return 0;
Maybe we should let users pass not boolean but CLOCK_* value (and reject
ones that we do not support) ? This way if someone wants to use some
other clock type in the future we won't need new ioctl.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2012-01-05 23:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 23:01 [RFC][PATCH] Input: Add infrastrucutre for monotonic event time stamps John Stultz
2012-01-05 23:28 ` Dmitry Torokhov [this message]
2012-01-05 23:51 ` John Stultz
2012-01-05 23:54 ` Chase Douglas
2012-01-06 0:19 ` John Stultz
2012-01-06 0:37 ` Chase Douglas
2012-01-06 0:44 ` Dmitry Torokhov
2012-01-06 0:52 ` Chase Douglas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105232853.GA1193@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=arve@android.com \
--cc=djkurtz@google.com \
--cc=john.stultz@linaro.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).