From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Henrik Rydberg" Subject: Re: [PATCH v2] Input: evdev - Add EVIOC mechanism to extract the MT slot state Date: Fri, 6 Jan 2012 21:14:34 +0100 Message-ID: <20120106201434.GA3174@polaris.bitmath.org> References: <1325863019-2242-1-git-send-email-rydberg@euromail.se> <20120106181845.GA22653@core.coreip.homeip.net> <20120106185544.GB2795@polaris.bitmath.org> <20120106191835.GA2998@polaris.bitmath.org> <4F074CAE.7010205@canonical.com> <20120106194815.GA3116@polaris.bitmath.org> <20120106200239.GB23619@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtprelay-b21.telenor.se ([195.54.99.212]:41021 "EHLO smtprelay-b21.telenor.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759038Ab2AFUOj (ORCPT ); Fri, 6 Jan 2012 15:14:39 -0500 Content-Disposition: inline In-Reply-To: <20120106200239.GB23619@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Chase Douglas , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, Jan 06, 2012 at 12:02:40PM -0800, Dmitry Torokhov wrote: > On Fri, Jan 06, 2012 at 08:48:15PM +0100, Henrik Rydberg wrote: > > > > Ok, maybe not to so easy after all, which probably answers my own > > > > question. Looks like a EVIOCGMTSLOT, taking both slot and event code > > > > as argument, would be the cleaner route to take. Another ioctl, how do we > > > > feel about that? > > > > > > What's the problem with userspace locking? > > > > The idea was to get by without it. > > > > Regarding ioctls, it does not seem realizable due to ioctl number > > exhaustion. > > I am prettu sure we cabn spare 1 ioctl number. We just need to pass slot > number not as part of ioctl number but in data instead. Like > EVIOCGKEYCODE works. Right, thanks. Perhaps we could even pass it as result data - returning all mt data in one go? With the purpose being to capture the full MT state, it ought to be both simpler and faster. Henrik