From: "Henrik Rydberg" <rydberg@euromail.se>
To: Jussi Pakkanen <jussi.pakkanen@canonical.com>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org
Subject: Re: [PATCH] Set buttonpad property on those bcm5974 devices that have a physical button.
Date: Tue, 10 Jan 2012 10:45:20 +0100 [thread overview]
Message-ID: <20120110094520.GA7582@polaris.bitmath.org> (raw)
In-Reply-To: <1326188164-6106-1-git-send-email-jussi.pakkanen@canonical.com>
Jussi,
On Tue, Jan 10, 2012 at 11:36:04AM +0200, Jussi Pakkanen wrote:
> ---
> drivers/input/mouse/bcm5974.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
> index 5ec617e..df3fd85 100644
> --- a/drivers/input/mouse/bcm5974.c
> +++ b/drivers/input/mouse/bcm5974.c
> @@ -876,6 +876,9 @@ static int bcm5974_probe(struct usb_interface *iface,
>
> input_dev->name = "bcm5974";
> input_dev->phys = dev->phys;
> + if (bcm5974_get_config(dev->udev)->caps & HAS_INTEGRATED_BUTTON) {
> + __set_bit(INPUT_PROP_BUTTONPAD, input_dev->propbit);
> + }
> usb_to_input_id(dev->udev, &input_dev->id);
> /* report driver capabilities via the version field */
> input_dev->id.version = cfg->caps;
> --
> 1.7.5.4
>
Besides being put in the wrong place, the already-defined local
variable is not used. Any particular reason for it? Otherwise, please
bundle the change with the rest in setup_events_to_report().
Thanks,
Henrik
next prev parent reply other threads:[~2012-01-10 9:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 9:36 [PATCH] Set buttonpad property on those bcm5974 devices that have a physical button Jussi Pakkanen
2012-01-10 9:45 ` Henrik Rydberg [this message]
2012-01-10 10:08 ` [PATCH v2] " Jussi Pakkanen
2012-01-10 10:22 ` Henrik Rydberg
2012-01-10 10:56 ` [PATCH v3] bcm5974: Set BUTTONPAD property Jussi Pakkanen
2012-01-10 11:42 ` Henrik Rydberg
2012-01-11 7:38 ` Dmitry Torokhov
2012-01-11 9:23 ` Chase Douglas
2012-01-11 10:04 ` Henrik Rydberg
2012-01-11 10:09 ` Chase Douglas
2012-01-11 17:18 ` Dmitry Torokhov
2012-01-11 21:36 ` Chase Douglas
2012-01-11 21:59 ` Dmitry Torokhov
2012-01-11 22:57 ` Chase Douglas
2012-01-12 0:22 ` Henrik Rydberg
2012-01-12 10:19 ` Chase Douglas
2012-01-17 16:39 ` Chase Douglas
2012-01-17 18:06 ` Dmitry Torokhov
2012-01-17 18:15 ` Henrik Rydberg
2012-01-17 18:24 ` Jason Gerecke
2012-01-17 19:21 ` Dmitry Torokhov
2012-01-17 20:27 ` Jason Gerecke
2012-01-17 20:40 ` Dmitry Torokhov
2012-01-17 21:10 ` Jason Gerecke
2012-01-17 18:25 ` Chase Douglas
2012-01-17 18:57 ` Henrik Rydberg
2012-01-17 19:06 ` Chase Douglas
2012-01-17 19:29 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110094520.GA7582@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=dmitry.torokhov@gmail.com \
--cc=jussi.pakkanen@canonical.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).