From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Michael Thalmeier <michael.thalmeier@hale.at>
Cc: "Samuel Ortiz" <sameo@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
michael@thalmeier.at
Subject: Re: [PATCH v2] input/mc13783-ts: add pdata to set conversion delay
Date: Wed, 11 Jan 2012 09:35:40 -0800 [thread overview]
Message-ID: <20120111173540.GC21047@core.coreip.homeip.net> (raw)
In-Reply-To: <1326278963-22510-1-git-send-email-michael.thalmeier@hale.at>
On Wed, Jan 11, 2012 at 11:49:23AM +0100, Michael Thalmeier wrote:
>
> +struct mc13xxx_ts_platform_data {
> + /* Delay between Touchscreen polarization and ADC Conversion.
> + * Given in clock ticks of a 32 kHz clock which gives a granularity of
> + * about 30.5ms */
> + char ato;
> +
> +#define MC13783_TS_ATO_FIRST 0
> +#define MC13783_TS_ATO_EACH 1
> + /* Use the ATO delay only for the first conversion or for each one */
> + char atox;
> +};
'char' for these 2 looks wrong, 2 u8, u8 and bool or int and bool would
be better.
Otherwise am OK with input bits.
Acked-by: Dmitry Torokhov <dtor@mail.ru>
--
Dmitry
next prev parent reply other threads:[~2012-01-11 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 10:49 [PATCH v2] input/mc13783-ts: add pdata to set conversion delay Michael Thalmeier
2012-01-11 17:35 ` Dmitry Torokhov [this message]
2012-01-11 19:21 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111173540.GC21047@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thalmeier@hale.at \
--cc=michael@thalmeier.at \
--cc=sameo@linux.intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).