* [PATCH] gpio_keys: fix struct device declared inside parameter list
@ 2012-01-12 9:11 Heiko Stübner
2012-01-31 21:27 ` Heiko Stübner
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stübner @ 2012-01-12 9:11 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input
A struct device parameter is used in the enable and disable callbacks to
distinguish between different gpio_keys devices.
Platforms that don't use these callbacks may not include struct device
at all, as seen on arch/arm/mach-s3c2410/mach-n30.c
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
include/linux/gpio_keys.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/gpio_keys.h b/include/linux/gpio_keys.h
index b5ca4b2..004ff33 100644
--- a/include/linux/gpio_keys.h
+++ b/include/linux/gpio_keys.h
@@ -1,6 +1,8 @@
#ifndef _GPIO_KEYS_H
#define _GPIO_KEYS_H
+struct device;
+
struct gpio_keys_button {
/* Configuration parameters */
unsigned int code; /* input event code (KEY_*, SW_*) */
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio_keys: fix struct device declared inside parameter list
2012-01-12 9:11 [PATCH] gpio_keys: fix struct device declared inside parameter list Heiko Stübner
@ 2012-01-31 21:27 ` Heiko Stübner
2012-02-03 8:37 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stübner @ 2012-01-31 21:27 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
Am Donnerstag 12 Januar 2012, 10:11:31 schrieb Heiko Stübner:
> A struct device parameter is used in the enable and disable callbacks to
> distinguish between different gpio_keys devices.
>
> Platforms that don't use these callbacks may not include struct device
> at all, as seen on arch/arm/mach-s3c2410/mach-n30.c
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
ping?
Thanks
Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio_keys: fix struct device declared inside parameter list
2012-01-31 21:27 ` Heiko Stübner
@ 2012-02-03 8:37 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2012-02-03 8:37 UTC (permalink / raw)
To: Heiko Stübner; +Cc: linux-input
On Tue, Jan 31, 2012 at 10:27:55PM +0100, Heiko Stübner wrote:
> Am Donnerstag 12 Januar 2012, 10:11:31 schrieb Heiko Stübner:
> > A struct device parameter is used in the enable and disable callbacks to
> > distinguish between different gpio_keys devices.
> >
> > Platforms that don't use these callbacks may not include struct device
> > at all, as seen on arch/arm/mach-s3c2410/mach-n30.c
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ping?
>
Applied, thank you Heiko.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-03 8:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-12 9:11 [PATCH] gpio_keys: fix struct device declared inside parameter list Heiko Stübner
2012-01-31 21:27 ` Heiko Stübner
2012-02-03 8:37 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).