From: "Henrik Rydberg" <rydberg@euromail.se>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mohan Pallaka <mpallaka@codeaurora.org>,
Kevin McNeely <kev@cypress.com>,
Shubhrajyoti Datta <omaplinuxkernel@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v9 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support
Date: Mon, 16 Jan 2012 14:14:24 +0100 [thread overview]
Message-ID: <20120116131424.GA6113@polaris.bitmath.org> (raw)
In-Reply-To: <1326508373-23444-1-git-send-email-javier@dowhile0.org>
Hi Javier,
> Cypress TrueTouch(tm) Standard Product controllers are found in
> a wide range of embedded devices. This driver add support for a
> variety of TTSP controllers.
>
> Since the hardware is capable of tracking identifiable contacts, multi-touch
> protocol type B (stateful) is used to report contact information.
>
> The driver is composed of a core driver that process the data sent by
> the contacts and a set of bus specific interface modules. This patch
> adds the base core TTSP driver.
>
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
> ---
>
> Changes for v9 suggested by Henrik Rydberg:
> - Simplify cyttsp_bl_app_valid() function
> - Remove retry logic since is already done in ttsp[read | write]_block_data
>
> drivers/input/touchscreen/Kconfig | 31 ++
> drivers/input/touchscreen/Makefile | 3 +
> drivers/input/touchscreen/cyttsp_core.c | 703 +++++++++++++++++++++++++++++++
> drivers/input/touchscreen/cyttsp_core.h | 141 ++++++
> include/linux/input/cyttsp.h | 69 +++
> 5 files changed, 947 insertions(+), 0 deletions(-)
> create mode 100644 drivers/input/touchscreen/cyttsp_core.c
> create mode 100644 drivers/input/touchscreen/cyttsp_core.h
> create mode 100644 include/linux/input/cyttsp.h
Looks reasonable now, so
Reviewed-by: Henrik Rydberg <rydberg@euromail.se>
Thanks for your patience.
Henrik
next prev parent reply other threads:[~2012-01-16 13:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-14 2:32 [PATCH v9 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support Javier Martinez Canillas
2012-01-14 2:32 ` [PATCH v9 2/3] Input: cyttsp - add support for Cypress TTSP touchscreen I2C bus interface Javier Martinez Canillas
2012-01-14 2:32 ` [PATCH v9 3/3] Input: cyttsp - add support for Cypress TTSP touchscreen SPI " Javier Martinez Canillas
2012-01-16 13:14 ` Henrik Rydberg [this message]
2012-01-16 22:28 ` [PATCH v9 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support Javier Martinez Canillas
2012-01-18 7:02 ` Javier Martinez Canillas
2012-01-18 9:12 ` Dmitry Torokhov
2012-01-18 9:20 ` Javier Martinez Canillas
2012-01-18 10:35 ` Javier Martinez Canillas
2012-01-18 17:47 ` Dmitry Torokhov
2012-01-18 21:35 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116131424.GA6113@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=dmitry.torokhov@gmail.com \
--cc=javier@dowhile0.org \
--cc=kev@cypress.com \
--cc=linux-input@vger.kernel.org \
--cc=mpallaka@codeaurora.org \
--cc=omaplinuxkernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).