From: Oliver Neukum <oneukum@suse.de>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, linux-input@vger.kernel.org,
Jiri Kosina <jkosina@suse.cz>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [RFC PATCH 1/3] v4l2-ctrls: fix ugly control name.
Date: Mon, 16 Jan 2012 14:00:00 +0100 [thread overview]
Message-ID: <201201161400.00203.oneukum@suse.de> (raw)
In-Reply-To: <4f4e18b94612a34be98e2304a4d9b0cef74acd39.1326716517.git.hans.verkuil@cisco.com>
Am Montag, 16. Januar 2012, 13:29:18 schrieb Hans Verkuil:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> drivers/media/video/v4l2-ctrls.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c
> index da1f4c2..35316f9 100644
> --- a/drivers/media/video/v4l2-ctrls.c
> +++ b/drivers/media/video/v4l2-ctrls.c
> @@ -588,7 +588,7 @@ const char *v4l2_ctrl_get_name(u32 id)
> case V4L2_CID_PILOT_TONE_ENABLED: return "Pilot Tone Feature Enabled";
> case V4L2_CID_PILOT_TONE_DEVIATION: return "Pilot Tone Deviation";
> case V4L2_CID_PILOT_TONE_FREQUENCY: return "Pilot Tone Frequency";
> - case V4L2_CID_TUNE_PREEMPHASIS: return "Pre-emphasis settings";
> + case V4L2_CID_TUNE_PREEMPHASIS: return "Pre-Emphasis";
> case V4L2_CID_TUNE_POWER_LEVEL: return "Tune Power Level";
> case V4L2_CID_TUNE_ANTENNA_CAPACITOR: return "Tune Antenna Capacitor";
>
This looks like generic code. What happens if a programm is looking for
this string?
Regards
Oliver
next prev parent reply other threads:[~2012-01-16 12:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 12:29 [RFC PATCH 0/3] New driver for the Keene USB FM Transmitter Hans Verkuil
2012-01-16 12:29 ` [RFC PATCH 1/3] v4l2-ctrls: fix ugly control name Hans Verkuil
2012-01-16 12:29 ` [RFC PATCH 2/3] radio-keene: add a driver for the Keene FM Transmitter Hans Verkuil
2012-01-16 12:44 ` Oliver Neukum
2012-01-16 13:02 ` Hans Verkuil
2012-01-16 13:11 ` Oliver Neukum
2012-01-16 17:28 ` Alan Cox
2012-01-16 12:46 ` Oliver Neukum
2012-01-16 13:03 ` Hans Verkuil
2012-01-16 13:15 ` Oliver Neukum
2012-01-16 12:29 ` [RFC PATCH 3/3] hid-core: ignore the Keene FM transmitter Hans Verkuil
2012-01-16 13:00 ` Oliver Neukum [this message]
2012-01-16 13:04 ` [RFC PATCH 1/3] v4l2-ctrls: fix ugly control name Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201161400.00203.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox