From: Dan Carpenter <dan.carpenter@oracle.com>
To: javier@dowhile0.org
Cc: linux-input@vger.kernel.org
Subject: re: Input: add Cypress TTSP capacitive multi-touch screen support
Date: Wed, 1 Feb 2012 12:40:39 +0300 [thread overview]
Message-ID: <20120201094039.GA20690@elgon.mountain> (raw)
Hello Javier Martinez Canillas,
This is a semi-automatic email about new static checker warnings.
The patch 4065d1e7b216: "Input: add Cypress TTSP capacitive
multi-touch screen support" from Jan 31, 2012, leads to the following
Smatch complaint:
drivers/input/touchscreen/cyttsp_core.c +526 cyttsp_probe()
warn: variable dereferenced before check 'dev' (see line 521)
drivers/input/touchscreen/cyttsp_core.c
520 {
521 const struct cyttsp_platform_data *pdata = dev->platform_data;
^^^^^
dereference.
522 struct cyttsp *ts;
523 struct input_dev *input_dev;
524 int error;
525
526 if (!dev || !bus_ops || !pdata || !pdata->name || irq <= 0) {
^^^^
check.
527 error = -EINVAL;
528 goto err_out;
"dev" is never NULL here so the check can be removed probably.
regards,
dan carpenter
next reply other threads:[~2012-02-01 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 9:40 Dan Carpenter [this message]
2012-02-10 0:04 ` Input: add Cypress TTSP capacitive multi-touch screen support Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201094039.GA20690@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=javier@dowhile0.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox