linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Chase Douglas <chase.douglas@canonical.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH resend] bcm5974: Add pointer and buttonpad properties
Date: Tue, 14 Feb 2012 16:19:03 +0100	[thread overview]
Message-ID: <20120214151903.GA5616@polaris.bitmath.org> (raw)
In-Reply-To: <1329193448-15219-1-git-send-email-chase.douglas@canonical.com>

Hi Chase,

On Mon, Feb 13, 2012 at 08:24:08PM -0800, Chase Douglas wrote:
> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
> ---
> I sent to the wrong mailing list address the first time. Sorry!
> 
>  drivers/input/mouse/bcm5974.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
> index 5ec617e..9faa049 100644
> --- a/drivers/input/mouse/bcm5974.c
> +++ b/drivers/input/mouse/bcm5974.c
> @@ -434,6 +434,9 @@ static void setup_events_to_report(struct input_dev *input_dev,
>  	__set_bit(BTN_LEFT, input_dev->keybit);
>  
>  	input_set_events_per_packet(input_dev, 60);
> +
> +	__set_bit(INPUT_PROP_POINTER, input->propbit);
> +	__set_bit(INPUT_PROP_BUTTONPAD, input->propbit);
>  }
>  
>  /* report button data as logical button state */
> -- 
> 1.7.9
>

I can take this for 3.4, but the patch needs a commit message. "In
order to move userspace in the direction of simpler and more accurate
device setup, emit device properties..."?

Thanks,
Henrik


  parent reply	other threads:[~2012-02-14 15:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14  4:24 [PATCH resend] bcm5974: Add pointer and buttonpad properties Chase Douglas
2012-02-14  5:07 ` Wanlong Gao
2012-02-14  5:40   ` Chase Douglas
2012-02-14 15:19 ` Henrik Rydberg [this message]
2012-02-14 15:23   ` Chase Douglas
2012-02-14 15:28     ` Mohamed Ikbel Boulabiar
2012-02-14 17:00       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120214151903.GA5616@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=chase.douglas@canonical.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).