From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: deepaksi <deepak.sikri@st.com>
Cc: Viresh KUMAR <viresh.kumar@st.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Armando VISCONTI <armando.visconti@st.com>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Vipin KUMAR <vipin.kumar@st.com>,
Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
Amit VIRDI <Amit.VIRDI@st.com>,
Pratyush ANAND <pratyush.anand@st.com>,
Bhupesh SHARMA <bhupesh.sharma@st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
Bhavna YADAV <bhavna.yadav@st.com>,
Vincenzo FRASCINO <Vincenzo.FRASCINO@st.com>,
Mirko GARDI <mirko.gardi@st.com>
Subject: Re: [PATCH 1/2] Input/spear-keyboard: Fix for balancing the enable_irq_wake in Power Mgmt
Date: Fri, 24 Feb 2012 01:02:39 -0800 [thread overview]
Message-ID: <20120224090239.GC10763@core.coreip.homeip.net> (raw)
In-Reply-To: <4F475131.6050506@st.com>
On Fri, Feb 24, 2012 at 02:28:25PM +0530, deepaksi wrote:
> Hi,
>
>
> On 2/24/2012 2:04 PM, Dmitry Torokhov wrote:
> >On Thu, Feb 23, 2012 at 03:10:51PM +0530, Viresh Kumar wrote:
> >>From: Deepak Sikri<deepak.sikri@st.com>
> >>
> >>This patch handles the fix for unbalanced irq for the cases when
> >>enable_irq_wake fails, and a warning related to same is displayed
> >>on the console. The workaround is handled at the driver level.
> >So why is the device marked as wakeup capable?
>
> The device is capable of wake up. There are cases in which the
> enable_irq_wake call may fail.
In this case I'd say the proper action would be to abort suspend instead
of continuing.
> This was specifically observed for ARM cortex architecture kernel
> implementation for GIC (PL390).
> The 2.6.37 kernel versions and before do not have the callbacks
> related to function that help to set up
> the wake up interrupts in GIC, and enable_irq_wake returns with an
> error code -ENXIO.
Right, but current mainline does have it set up properly, correct? IOW
we do not really expect enable_irq_wake() to fail if device is wakeup
capable, correct?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2012-02-24 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 9:40 [PATCH 1/2] Input/spear-keyboard: Fix for balancing the enable_irq_wake in Power Mgmt Viresh Kumar
2012-02-23 9:40 ` [PATCH 2/2] Input/spear-keyboard: Provide thaw and poweroff routines Viresh Kumar
2012-02-23 10:35 ` Viresh Kumar
2012-02-23 11:29 ` Shubhrajyoti
2012-02-23 11:56 ` Viresh Kumar
2012-02-23 11:59 ` Viresh Kumar
2012-02-23 12:11 ` Shubhrajyoti
2012-02-24 5:29 ` [PATCH V2] " Viresh Kumar
2012-02-24 8:34 ` [PATCH 1/2] Input/spear-keyboard: Fix for balancing the enable_irq_wake in Power Mgmt Dmitry Torokhov
2012-02-24 8:58 ` deepaksi
2012-02-24 9:02 ` Dmitry Torokhov [this message]
2012-02-24 9:12 ` deepaksi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224090239.GC10763@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=Amit.VIRDI@st.com \
--cc=Vincenzo.FRASCINO@st.com \
--cc=armando.visconti@st.com \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=deepak.sikri@st.com \
--cc=linux-input@vger.kernel.org \
--cc=mirko.gardi@st.com \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=shiraz.hashim@st.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).