From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH 1/2] Input/spear-keyboard: Fix for balancing the
 enable_irq_wake in Power Mgmt
Date: Fri, 24 Feb 2012 01:02:39 -0800
Message-ID: <20120224090239.GC10763@core.coreip.homeip.net>
References: <c65186b4c05cca4b233a56630a87b7e7c94ccc9d.1329990021.git.viresh.kumar@st.com>
 <20120224083409.GD18291@core.coreip.homeip.net>
 <4F475131.6050506@st.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-input-owner@vger.kernel.org>
Received: from mail-pz0-f46.google.com ([209.85.210.46]:52027 "EHLO
	mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756034Ab2BXJCo (ORCPT
	<rfc822;linux-input@vger.kernel.org>);
	Fri, 24 Feb 2012 04:02:44 -0500
Received: by daed14 with SMTP id d14so2267317dae.19
        for <linux-input@vger.kernel.org>; Fri, 24 Feb 2012 01:02:44 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <4F475131.6050506@st.com>
Sender: linux-input-owner@vger.kernel.org
List-Id: linux-input@vger.kernel.org
To: deepaksi <deepak.sikri@st.com>
Cc: Viresh KUMAR <viresh.kumar@st.com>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>, Armando VISCONTI <armando.visconti@st.com>, Shiraz HASHIM <shiraz.hashim@st.com>, Vipin KUMAR <vipin.kumar@st.com>, Rajeev KUMAR <rajeev-dlh.kumar@st.com>, Vipul Kumar SAMAR <vipulkumar.samar@st.com>, Amit VIRDI <Amit.VIRDI@st.com>, Pratyush ANAND <pratyush.anand@st.com>, Bhupesh SHARMA <bhupesh.sharma@st.com>, "viresh.linux@gmail.com" <viresh.linux@gmail.com>, Bhavna YADAV <bhavna.yadav@st.com>, Vincenzo FRASCINO <Vincenzo.FRASCINO@st.com>, Mirko GARDI <mirko.gardi@st.com>

On Fri, Feb 24, 2012 at 02:28:25PM +0530, deepaksi wrote:
> Hi,
> 
> 
> On 2/24/2012 2:04 PM, Dmitry Torokhov wrote:
> >On Thu, Feb 23, 2012 at 03:10:51PM +0530, Viresh Kumar wrote:
> >>From: Deepak Sikri<deepak.sikri@st.com>
> >>
> >>This patch handles the fix for unbalanced irq for the cases when
> >>enable_irq_wake fails, and a warning related to same is displayed
> >>on the console. The workaround is handled at the driver level.
> >So why is the device marked as wakeup capable?
> 
> The device is capable of wake up. There are cases in which the
> enable_irq_wake call may fail.

In this case I'd say the proper action would be to abort suspend instead
of continuing.

> This was specifically observed for ARM cortex architecture kernel
> implementation for GIC (PL390).
> The 2.6.37 kernel versions and before do not have the callbacks
> related to function that help to set up
> the wake up interrupts  in GIC, and enable_irq_wake returns with an
> error code -ENXIO.

Right, but current mainline does have it set up properly, correct? IOW
we do not really expect enable_irq_wake() to fail if device is wakeup
capable, correct?

Thanks.

-- 
Dmitry