From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Manoj Iyer <manoj.iyer@canonical.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] Input: atkbd - Add force relese key quirk for HP ProBook
Date: Tue, 28 Feb 2012 22:17:15 -0800 [thread overview]
Message-ID: <20120229061715.GA13131@core.coreip.homeip.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1202282351510.5366@happy>
Hi Manoj,
On Tue, Feb 28, 2012 at 11:56:22PM -0600, Manoj Iyer wrote:
> Dimitry,
>
> This quirk helps a few HP ProBooks to make brightness keys
> typematic. Can you please tell me why you think its better handling
> this in user space?
Because there are too many broken laptops to quirk them all in kernel as
every quirk takes non-swappable kernel memory whereas userspace solution
only takes disk space.
> I see other quirks similar to this in atkbd,
> just trying to understand.
These were added before I implemented support for allowing marking some
of the keys as "force release" via sysfs attribute.
> Yes, we did quirk this in udev rules to
> make brightness keys works as expected. But thought it might help
> others who see this issue with HP ProBooks by quirking it in kernel.
>
If you submit your quirk to udev maintainers you will help others
exactly the same as with kernel patch.
Thanks.
--
Dmitry
P.S. Please do not top post.
next prev parent reply other threads:[~2012-02-29 6:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 0:36 [PATCH] Input: atkbd - Add force relese key quirk for HP ProBook Manoj Iyer
2012-02-29 0:36 ` Manoj Iyer
2012-02-29 0:46 ` Greg KH
2012-02-29 1:03 ` Dmitry Torokhov
2012-02-29 5:56 ` Manoj Iyer
2012-02-29 6:17 ` Dmitry Torokhov [this message]
2012-02-29 6:57 ` Manoj Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229061715.GA13131@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manoj.iyer@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).