* [PATCH v2 0/2] input: add MAX8997-haptic driver
@ 2012-03-07 8:02 Chanwoo Choi
2012-03-07 8:29 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Chanwoo Choi @ 2012-03-07 8:02 UTC (permalink / raw)
To: linux-input, Dmitry Torokhov
Cc: sameo, broonie, linux-kernel, kyungmin.park, myungjoo.ham
MAX8997 has several features in a single chip,
This patchset supports unimplemented haptic driver of MAX8997.
v2
- code clean and remove unnecessary code according to comment of Dmitry
Torokhov
Donggeun Kim (2):
mfd: add platform data for MAX8997 haptic driver
input: add driver support for MAX8997-haptic
drivers/input/misc/Kconfig | 12 ++
drivers/input/misc/Makefile | 1 +
drivers/input/misc/max8997_haptic.c | 371
+++++++++++++++++++++++++++++++++++
include/linux/mfd/max8997.h | 53 +++++-
4 files changed, 436 insertions(+), 1 deletions(-)
create mode 100644 drivers/input/misc/max8997_haptic.c
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/2] input: add MAX8997-haptic driver
2012-03-07 8:02 [PATCH v2 0/2] input: add MAX8997-haptic driver Chanwoo Choi
@ 2012-03-07 8:29 ` Dmitry Torokhov
2012-03-12 8:31 ` Chanwoo Choi
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2012-03-07 8:29 UTC (permalink / raw)
To: Chanwoo Choi
Cc: linux-input, sameo, broonie, linux-kernel, kyungmin.park,
myungjoo.ham
Hi Chanwoo,
On Wed, Mar 07, 2012 at 05:02:49PM +0900, Chanwoo Choi wrote:
> MAX8997 has several features in a single chip,
> This patchset supports unimplemented haptic driver of MAX8997.
>
> v2
> - code clean and remove unnecessary code according to comment of Dmitry
> Torokhov
Could you please tell me if the version of the patch I sent to you
worked or not?
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/2] input: add MAX8997-haptic driver
2012-03-07 8:29 ` Dmitry Torokhov
@ 2012-03-12 8:31 ` Chanwoo Choi
2012-03-13 5:30 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Chanwoo Choi @ 2012-03-12 8:31 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: linux-input, sameo, broonie, linux-kernel, kyungmin.park,
myungjoo.ham
Hi Dmitry,
On 03/07/2012 05:29 PM, Dmitry Torokhov wrote:
> Hi Chanwoo,
>
>
> On Wed, Mar 07, 2012 at 05:02:49PM +0900, Chanwoo Choi wrote:
>> MAX8997 has several features in a single chip,
>> This patchset supports unimplemented haptic driver of MAX8997.
>>
>> v2
>> - code clean and remove unnecessary code according to comment of Dmitry
>> Torokhov
>
> Could you please tell me if the version of the patch I sent to you
> worked or not?
It isn't worked because it use the mutex lock in irq handler stack.
so, I resend v3 patch of max8997-haptic driver after modifying it.
Best Regards,
Chanwoo Choi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/2] input: add MAX8997-haptic driver
2012-03-12 8:31 ` Chanwoo Choi
@ 2012-03-13 5:30 ` Dmitry Torokhov
2012-03-13 5:39 ` Chanwoo Choi
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2012-03-13 5:30 UTC (permalink / raw)
To: Chanwoo Choi
Cc: linux-input, sameo, broonie, linux-kernel, kyungmin.park,
myungjoo.ham
On Mon, Mar 12, 2012 at 05:31:24PM +0900, Chanwoo Choi wrote:
> Hi Dmitry,
>
> On 03/07/2012 05:29 PM, Dmitry Torokhov wrote:
> > Hi Chanwoo,
> >
> >
> > On Wed, Mar 07, 2012 at 05:02:49PM +0900, Chanwoo Choi wrote:
> >> MAX8997 has several features in a single chip,
> >> This patchset supports unimplemented haptic driver of MAX8997.
> >>
> >> v2
> >> - code clean and remove unnecessary code according to comment of Dmitry
> >> Torokhov
> >
> > Could you please tell me if the version of the patch I sent to you
> > worked or not?
>
> It isn't worked because it use the mutex lock in irq handler stack.
> so, I resend v3 patch of max8997-haptic driver after modifying it.
Hmm, my patch did not add taking mutex in irq context, I presume you are
talking about max8997->iolock that is taken in max8997_write_reg... OK,
I see...
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/2] input: add MAX8997-haptic driver
2012-03-13 5:30 ` Dmitry Torokhov
@ 2012-03-13 5:39 ` Chanwoo Choi
0 siblings, 0 replies; 5+ messages in thread
From: Chanwoo Choi @ 2012-03-13 5:39 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: linux-input, sameo, broonie, linux-kernel, kyungmin.park,
myungjoo.ham
On 03/13/2012 02:30 PM, Dmitry Torokhov wrote:
> On Mon, Mar 12, 2012 at 05:31:24PM +0900, Chanwoo Choi wrote:
>> Hi Dmitry,
>>
>> On 03/07/2012 05:29 PM, Dmitry Torokhov wrote:
>>> Hi Chanwoo,
>>>
>>>
>>> On Wed, Mar 07, 2012 at 05:02:49PM +0900, Chanwoo Choi wrote:
>>>> MAX8997 has several features in a single chip,
>>>> This patchset supports unimplemented haptic driver of MAX8997.
>>>>
>>>> v2
>>>> - code clean and remove unnecessary code according to comment of Dmitry
>>>> Torokhov
>>>
>>> Could you please tell me if the version of the patch I sent to you
>>> worked or not?
>>
>> It isn't worked because it use the mutex lock in irq handler stack.
>> so, I resend v3 patch of max8997-haptic driver after modifying it.
>
> Hmm, my patch did not add taking mutex in irq context, I presume you are
> talking about max8997->iolock that is taken in max8997_write_reg... OK,
> I see...
>
You're right. I'm sorry about my ambiguous reply for you.
Best Regards,
Chanwoo Choi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-13 5:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-07 8:02 [PATCH v2 0/2] input: add MAX8997-haptic driver Chanwoo Choi
2012-03-07 8:29 ` Dmitry Torokhov
2012-03-12 8:31 ` Chanwoo Choi
2012-03-13 5:30 ` Dmitry Torokhov
2012-03-13 5:39 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).