From: "Henrik Rydberg" <rydberg@bitmath.se>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Stephane Chatty <chatty@enac.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] HID: multitouch: add support for eGalax 0x722a
Date: Mon, 12 Mar 2012 14:02:33 +0100 [thread overview]
Message-ID: <20120312130233.GA7456@polaris.bitmath.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1203121339550.18356@pobox.suse.cz>
> > Thanks Jiri.
> > How about patches 2,3 and 5?
>
> I just needed some more time to review those. They are now in my tree as
> well.
>
> Patch #4 is still under discussion, and thus on hold.
I am ok with the approach, given that a better one would require a
substantial amount of extra work. Also, since this is all internal
changes, the current patchset does not hinder an eventual improvement
later on. For patch 3, it would be good to at least put the test for
the hid-multitouch driver in a separate function. For patch 4, the
variable name "multitouch" is a bit too generic given the very
specific usage.
Thanks,
Henrik
next prev parent reply other threads:[~2012-03-12 13:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 16:57 [patch 0/5] Autohandling of multitouch devices through hid-multitouch benjamin.tissoires
2012-03-06 16:57 ` [PATCH 1/5] HID: multitouch: add support for eGalax 0x722a benjamin.tissoires
2012-03-09 12:29 ` Jiri Kosina
2012-03-10 6:31 ` Benjamin Tissoires
2012-03-12 12:40 ` Jiri Kosina
2012-03-12 13:02 ` Henrik Rydberg [this message]
2012-03-06 16:57 ` [PATCH 2/5] HID: multitouch: fix handling of buggy reports descriptors for Dell ST2220T benjamin.tissoires
2012-03-12 10:25 ` Jiri Kosina
2012-03-06 16:57 ` [PATCH 3/5] HID: handle all multitouch devices through hid-multitouch benjamin.tissoires
2012-03-06 16:57 ` [PATCH 4/5] HID: autoload hid-multitouch as needed benjamin.tissoires
2012-03-07 21:36 ` Jiri Kosina
2012-03-08 10:57 ` Henrik Rydberg
2012-03-08 11:21 ` Stéphane Chatty
2012-03-08 11:30 ` Henrik Rydberg
2012-03-08 11:48 ` Stéphane Chatty
2012-03-08 12:23 ` Henrik Rydberg
2012-03-08 22:47 ` Stéphane Chatty
2012-03-12 16:18 ` Jiri Kosina
2012-03-12 15:57 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1203121650500.18356-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2012-03-12 17:42 ` Marcel Holtmann
2012-03-12 20:47 ` Stéphane Chatty
2012-03-12 22:21 ` Jiri Kosina
2012-03-13 10:17 ` Stéphane Chatty
2012-03-13 16:13 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1203131710120.18356-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2012-03-13 18:14 ` Stéphane Chatty
2012-03-16 11:26 ` Jiri Kosina
2012-03-06 16:57 ` [PATCH 5/5] HID: multitouch: detect serial protocol benjamin.tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312130233.GA7456@polaris.bitmath.org \
--to=rydberg@bitmath.se \
--cc=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).