From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: simon@mungewell.org
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Bauer <michael@m-bauer.org>,
Michal Maly <madcatxster@gmail.com>
Subject: Re: [PATCH 1/2] HID: hid-lg4ff add support for G27 LEDs
Date: Mon, 12 Mar 2012 18:32:35 +0000 [thread overview]
Message-ID: <20120312183235.GA28451@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <3391c87c6cc142e1b50b73eb78e70dc8.squirrel@mungewell.org>
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
On Mon, Mar 12, 2012 at 02:19:25PM -0400, simon@mungewell.org wrote:
> > On Mon, Mar 12, 2012 at 02:04:14PM -0400, simon@mungewell.org wrote:
> >> At the moment you'd just drive the LEDs simply, ie:
> >> $ echo 31 > /sys/bus/hid/devices/.../leds
> > Shouldn't this be using the LED subsystem the kernel already has?
> The LED subsystem appears to be aim at controller chips (ie. lp3944) which
> are connected to a bus (I2C) in a generalised form. I guess people might
> be doing 'blinken light' type systems.
Not really, it's aimed at supporting LEDs in general. Obviously most of
the drivers are for specific controller chips which makes them more
visible but there's also things like the triggers.
> The LEDs on the G27 are very much more specific, mounted on the yoke of
> the gaming wheel.
> Would this require the use/complexity of the LED subsystem?
Well, it'd mean that applications that know how to drive LEDs will be
able to use the LEDs on this wheel with less per device knowledge which
seems like a useful thing and if someone wants to remap a LED to "new
mail" or whatever that'll be easier (nethack has the mailer daemon
deliver a scroll of mail!).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-12 18:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 15:17 [PATCH 1/2] HID: hid-lg4ff add support for G27 LEDs Simon Wood
2012-03-12 15:17 ` [PATCH 2/2] HID: hid-lg4ff clean up attribution Simon Wood
2012-03-12 15:46 ` [PATCH 1/2] HID: hid-lg4ff add support for G27 LEDs Jiri Kosina
2012-03-12 18:04 ` simon
2012-03-12 18:07 ` Mark Brown
2012-03-12 18:19 ` simon
2012-03-12 18:32 ` Mark Brown [this message]
2012-03-12 19:05 ` simon
2012-03-12 19:12 ` Mark Brown
2012-03-13 8:23 ` Jiri Kosina
2012-03-12 16:09 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2012-03-13 21:08 simon
2012-03-13 21:11 ` simon
2012-03-13 21:24 ` Jiri Kosina
2012-03-13 21:44 ` simon
2012-03-14 1:51 ` simon
2012-04-13 12:59 [PATCH] HID: hid-lg4ff: Add " Jiri Kosina
2012-04-18 7:03 ` [PATCH 1/2] " Simon Wood
2012-04-18 11:24 ` Jiri Kosina
2012-04-18 14:58 ` simon
2012-04-20 10:05 ` Jiri Kosina
2012-04-21 12:41 ` Simon Wood
2012-04-23 18:55 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312183235.GA28451@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madcatxster@gmail.com \
--cc=michael@m-bauer.org \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).