From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chris Bagwell <chris@cnpbagwell.com>
Cc: Jason Gerecke <killertofu@gmail.com>,
linux-input@vger.kernel.org,
linuxwacom-devel@lists.sourceforge.net
Subject: Re: [PATCH] input: wacom: Fix physical size calculation for 3rd-gen Bamboo
Date: Mon, 12 Mar 2012 22:21:12 -0700 [thread overview]
Message-ID: <20120313052112.GA9449@core.coreip.homeip.net> (raw)
In-Reply-To: <CAGzDe_aNMddbMCnK61c3J+3zTOtuM9EMkf5RhbfBs0oodnsNoA@mail.gmail.com>
On Mon, Mar 12, 2012 at 10:25:47PM -0500, Chris Bagwell wrote:
> On Mon, Mar 12, 2012 at 5:53 PM, Jason Gerecke <killertofu@gmail.com> wrote:
> > This calculation determines the physical dimensions of the tablet,
> > used later on in calculate_touch_res to obtain the touch sensor
> > resolution.
> >
> > Instead of dividing the logical size by the resolution, the current
> > code performs a multiplication. This doesn't pose a problem for the
> > 3rd-gen Bamboo since the resolution and scale factor happen to be
> > identical, but will produce an incorrect result for other cases.
> >
> > Signed-off-by: Jason Gerecke <killertofu@gmail.com>
>
> Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2012-03-13 5:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 22:53 [PATCH] input: wacom: Fix physical size calculation for 3rd-gen Bamboo Jason Gerecke
2012-03-13 3:25 ` Chris Bagwell
2012-03-13 5:21 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313052112.GA9449@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chris@cnpbagwell.com \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linuxwacom-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).