From: Samuel Ortiz <sameo@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
linux-input@vger.kernel.org, broonie@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org, kyungmin.park@samsung.com,
myungjoo.ham@samsung.com
Subject: Re: [PATCH v3 2/2] input: add driver support for MAX8997-haptic
Date: Fri, 16 Mar 2012 18:48:02 +0100 [thread overview]
Message-ID: <20120316174802.GI20524@sortiz-mobl> (raw)
In-Reply-To: <20120314154828.GA24964@core.coreip.homeip.net>
Hi Dmitry,
On Wed, Mar 14, 2012 at 08:48:28AM -0700, Dmitry Torokhov wrote:
> On Wed, Mar 14, 2012 at 11:47:42PM +0900, Chanwoo Choi wrote:
> > Hi Dmitry,
> >
> > > This is not proper locking between playing effect and suspend. Now that
> > > you are using workqueue you need to synchronize access with it, not with
> > > play_effect method.
> > >
> > > Does the following patch work for you?
> > >
> >
> > Your patch is worked on TRATS board based on EXYNOS4210 but, you should
> > apply following patch because 'chip->enabled' is used on
> > max8997_haptic_configure() function to enable/disable haptic motor.
>
> OK, excellent. I'll pick up this fix and apply the driver for 3.4 queue,
> thanks!
Your patch depends on the MFD changes Choi sent along the input driver. I
think it would make more sense for me to take it. What do you think ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2012-03-16 17:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 8:31 [PATCH v3 2/2] input: add driver support for MAX8997-haptic Chanwoo Choi
2012-03-14 8:46 ` Dmitry Torokhov
2012-03-14 11:54 ` Chanwoo Choi
2012-03-14 14:47 ` Chanwoo Choi
2012-03-14 15:48 ` Dmitry Torokhov
2012-03-16 17:48 ` Samuel Ortiz [this message]
2012-03-16 17:55 ` Dmitry Torokhov
2012-03-16 18:56 ` Samuel Ortiz
2012-03-16 19:27 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316174802.GI20524@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).