From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v3 2/2] input: add driver support for MAX8997-haptic Date: Fri, 16 Mar 2012 12:27:35 -0700 Message-ID: <20120316192735.GA19351@core.coreip.homeip.net> References: <4F5DB459.9090701@samsung.com> <20120314084652.GC3964@core.coreip.homeip.net> <4F60AF8E.7050900@samsung.com> <20120314154828.GA24964@core.coreip.homeip.net> <20120316174802.GI20524@sortiz-mobl> <20120316175524.GA19275@core.coreip.homeip.net> <20120316185626.GO20524@sortiz-mobl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:41595 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754734Ab2CPT1k (ORCPT ); Fri, 16 Mar 2012 15:27:40 -0400 Content-Disposition: inline In-Reply-To: <20120316185626.GO20524@sortiz-mobl> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Samuel Ortiz Cc: Chanwoo Choi , linux-input@vger.kernel.org, broonie@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, myungjoo.ham@samsung.com On Fri, Mar 16, 2012 at 07:56:26PM +0100, Samuel Ortiz wrote: > Hi Dmitry, > > On Fri, Mar 16, 2012 at 10:55:24AM -0700, Dmitry Torokhov wrote: > > > > OK, excellent. I'll pick up this fix and apply the driver for 3.4 queue, > > > > thanks! > > > Your patch depends on the MFD changes Choi sent along the input driver. I > > > think it would make more sense for me to take it. What do you think ? > > > > I think that splitting required platform data definitions from the > > driver into separate patch is quite pointless. > Hmm, you're right on this one. > > > I often see a driver > > split in 3+ patches - headers, the driver itself and Kconfig/makefile > > changes and I wonder what made them do it... > > > > Anyway, below is the consolidated patch I was going to apply to my tree, > > but if you want to go through yours - feel free to apply it. > No, I think it makes sense for you to take it. Add my: > Acked-by: Samuel Ortiz > > if you feel it's needed. I will, thank you. -- Dmitry