From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH V2 2/2] Input: spear-keyboard: add device tree bindings Date: Tue, 27 Mar 2012 00:51:52 -0700 Message-ID: <20120327075152.GA5433@core.coreip.homeip.net> References: <4aba6f2cd9f050f419660555bdb661915c1be9b1.1332826100.git.viresh.kumar@st.com> <20120327071335.GB1521@core.coreip.homeip.net> <4F716E4F.4050408@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:54527 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752132Ab2C0Hv5 (ORCPT ); Tue, 27 Mar 2012 03:51:57 -0400 Received: by pbcun15 with SMTP id un15so7072461pbc.19 for ; Tue, 27 Mar 2012 00:51:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <4F716E4F.4050408@st.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Viresh Kumar Cc: "swarren@nvidia.com" , "olof@lixom.net" , "devicetree-discuss@lists.ozlabs.org" , "linux-input@vger.kernel.org" , spear-devel , "viresh.linux@gmail.com" , "sr@denx.de" On Tue, Mar 27, 2012 at 01:07:51PM +0530, Viresh Kumar wrote: > On 3/27/2012 12:43 PM, Dmitry Torokhov wrote: > > I think the opposite order woudl make more sense - if pdata is supplied > > by the platform code then we should use it, otherwise try to see if > > there is OF data available instead. This way one can easily override OF > > data, if needed. > > Okay. > > Just for better understanding, why should we give more preference to pdata? > > I thought, a single image with pdata can be booted with or without DT > support for keyboard. So, if we are booting without of DT for keyboard, > then use pdata, otherwise use DT data. My reasoning is that device tree is in firmware and it might be desirable to override firmware in certain cases. Thanks. -- Dmitry