From: Dan Carpenter <dan.carpenter@oracle.com>
To: Roland Stigge <stigge@antcom.de>
Cc: devel@driverdev.osuosl.org, srinivas.bakki@nxp.com,
linux-usb@vger.kernel.org, broonie@opensource.wolfsonmicro.com,
gregkh@linuxfoundation.org, thierry.reding@avionic-design.de,
linux-kernel@vger.kernel.org, kevin.wells@nxp.com,
marek.vasut@gmail.com, arm@kernel.org,
linux-input@vger.kernel.org, axel.lin@gmail.com,
dmitry.torokhov@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/8] ohci-nxp: Driver cleanup
Date: Tue, 17 Apr 2012 23:57:41 +0300 [thread overview]
Message-ID: <20120417205740.GI6498@mwanda> (raw)
In-Reply-To: <1334682507-15055-2-git-send-email-stigge@antcom.de>
On Tue, Apr 17, 2012 at 07:08:20PM +0200, Roland Stigge wrote:
> @@ -435,6 +436,7 @@ static int __devinit usb_hcd_nxp_probe(s
> }
>
> __raw_writel(__raw_readl(USB_CTRL) | USB_HOST_NEED_CLK_EN, USB_CTRL);
> + __raw_writel(__raw_readl(USB_CTRL) & ~USB_DEV_NEED_CLK_EN, USB_CTRL);
>
> /* Set to enable all needed USB clocks */
> __raw_writel(USB_CLOCK_MASK, USB_OTG_CLK_CTRL);
What does this chunk do? Is this part of the "* Fixed controller
initialization (bits)" bullet point? How does it affect the user?
Should it be included in the 3.4 kernel?
Generally bug fixes, cleanups, and new features should go into
different patches. If you use "git citool" then you can highlight
and right click on the lines you want to go into the patch.
regards,
dan carpenter
next prev parent reply other threads:[~2012-04-17 20:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 17:08 [PATCH v2 0/8] Second patchset for LPC32xx device tree conversion Roland Stigge
2012-04-17 17:08 ` [PATCH v2 1/8] ohci-nxp: Driver cleanup Roland Stigge
2012-04-17 20:36 ` Arnd Bergmann
2012-04-17 21:03 ` Roland Stigge
2012-04-17 20:57 ` Dan Carpenter [this message]
2012-04-18 8:23 ` Roland Stigge
2012-04-18 4:55 ` Thierry Reding
2012-04-17 17:08 ` [PATCH v2 2/8] ohci-nxp: Device tree support Roland Stigge
2012-04-17 17:08 ` [PATCH v2 3/8] ARM: LPC32xx: clock.c update Roland Stigge
2012-04-17 21:09 ` Dan Carpenter
2012-04-18 8:33 ` Roland Stigge
2012-04-17 17:08 ` [PATCH v2 4/8] ARM: LPC32xx: Remove obsolete platform Kconfig Roland Stigge
2012-04-17 17:08 ` [PATCH v2 5/8] input: Device tree support for LPC32xx touchscreen Roland Stigge
2012-04-17 17:08 ` [PATCH v2 6/8] iio: lpc32xx-adc: Remove driver conflict due to device tree Roland Stigge
[not found] ` <1334682507-15055-1-git-send-email-stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>
2012-04-17 17:08 ` [PATCH v2 7/8] ARM: LPC32xx: DTS files for device tree conversion Roland Stigge
[not found] ` <1334682507-15055-8-git-send-email-stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>
2012-04-18 5:46 ` Thierry Reding
[not found] ` <20120418054615.GB17506-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-04-18 8:10 ` Arnd Bergmann
2012-04-18 8:36 ` Arnd Bergmann
2012-04-17 17:08 ` [PATCH v2 8/8] ARM: LPC32xx: Device tree support Roland Stigge
2012-04-18 6:02 ` Thierry Reding
2012-04-18 8:15 ` Arnd Bergmann
[not found] ` <20120418060230.GC17506-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-04-18 12:30 ` Roland Stigge
2012-04-18 14:01 ` Arnd Bergmann
2012-04-17 20:50 ` [PATCH v2 0/8] Second patchset for LPC32xx device tree conversion Dan Carpenter
2012-04-18 8:00 ` Roland Stigge
2012-04-18 8:06 ` Arnd Bergmann
2012-04-18 9:36 ` Dan Carpenter
2012-04-18 11:00 ` Arnd Bergmann
2012-04-18 12:14 ` Dan Carpenter
2012-04-18 16:56 ` Mark Brown
2012-04-19 14:21 ` Arnd Bergmann
2012-04-18 10:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417205740.GI6498@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arm@kernel.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=srinivas.bakki@nxp.com \
--cc=stigge@antcom.de \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).