From: Jonathan Corbet <corbet@lwn.net>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: linux-media@vger.kernel.org,
Jean-Francois Moine <moinejf@free.fr>,
linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Johann Deneux <johann.deneux@gmail.comx>,
Anssi Hannula <anssi.hannula@gmail.com>
Subject: Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)
Date: Mon, 23 Apr 2012 14:16:25 -0600 [thread overview]
Message-ID: <20120423141625.0138bbeb@lwn.net> (raw)
In-Reply-To: <1335187267-27940-1-git-send-email-ospite@studenti.unina.it>
On Mon, 23 Apr 2012 15:21:04 +0200
Antonio Ospite <ospite@studenti.unina.it> wrote:
> Jonathan, maybe fixp_sin() and fixp_cos() can be used in
> drivers/media/video/ov7670.c too where currently ov7670_sine() and
> ov7670_cosine() are defined, but I didn't want to send a patch I could
> not test.
Seems like a good idea. No reason to have multiple such hacks in the
kernel; I'll look at dumping the ov7670 version when I get a chance. That
may not be all that soon, though; life is a bit challenging at the moment.
One concern is that if we're going to add users to fixp-arith.h, some of
it should maybe go to a C file. Otherwise we'll create duplicated copies
of the cos_table array for each user. I'm not sure the functions need to
be inline either; nobody expects cos() to be blindingly fast.
Thanks,
jon
next prev parent reply other threads:[~2012-04-23 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 13:21 [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h) Antonio Ospite
2012-04-23 13:21 ` [PATCH 2/3] Input: move drivers/input/fixp-arith.h to include/linux Antonio Ospite
2012-04-23 16:16 ` Dmitry Torokhov
2012-04-23 13:21 ` [PATCH 3/3] [media] gspca - ov534: Add Hue control Antonio Ospite
2012-04-23 13:31 ` [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h) Antonio Ospite
2012-04-23 16:17 ` Dmitry Torokhov
2012-04-23 20:16 ` Jonathan Corbet [this message]
2012-04-30 13:51 ` Antonio Ospite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423141625.0138bbeb@lwn.net \
--to=corbet@lwn.net \
--cc=anssi.hannula@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=johann.deneux@gmail.comx \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=ospite@studenti.unina.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).