From: "Henrik Rydberg" <rydberg@euromail.se>
To: Gustavo Padovan <gustavo@padovan.org>,
Jiri Kosina <jkosina@suse.cz>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] hid: Create a generic device group
Date: Tue, 24 Apr 2012 00:31:46 +0200 [thread overview]
Message-ID: <20120423223146.GA6595@polaris.bitmath.org> (raw)
In-Reply-To: <20120423212659.GD18564@joana>
Hi Gustavo,
> > @@ -586,12 +586,12 @@ struct hid_descriptor {
> > struct hid_class_descriptor desc[1];
> > } __attribute__ ((packed));
> >
> > -#define HID_DEVICE(b, ven, prod) \
> > - .bus = (b), \
> > - .vendor = (ven), .product = (prod)
> > -
> > -#define HID_USB_DEVICE(ven, prod) HID_DEVICE(BUS_USB, ven, prod)
> > -#define HID_BLUETOOTH_DEVICE(ven, prod) HID_DEVICE(BUS_BLUETOOTH, ven, prod)
> > +#define HID_DEVICE(b, g, ven, prod) \
> > + .bus = (b), .group = (g), .vendor = (ven), .product = (prod)
> > +#define HID_USB_DEVICE(ven, prod) \
> > + .bus = BUS_USB, .vendor = (ven), .product = (prod)
> > +#define HID_BLUETOOTH_DEVICE(ven, prod) \
> > + .bus = BUS_BLUETOOTH, .vendor = (ven), .product = (prod)
>
> It seems we don't use this macro anywhere else, why did you keep it?
It is actually used extensively in device lists, see for instance in
drivers/hid/hid-core.c.
Henrik
next prev parent reply other threads:[~2012-04-23 22:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 10:07 [PATCH v3 0/6] hid: Introduce device groups Henrik Rydberg
2012-04-23 10:07 ` [PATCH v2 1/6] hid: Add device group to modalias Henrik Rydberg
2012-04-23 10:07 ` [PATCH 2/6] hid: Scan the device for group info before adding it Henrik Rydberg
2012-04-24 12:31 ` Jiri Kosina
2012-04-24 12:41 ` Henrik Rydberg
2012-04-23 10:07 ` [PATCH v2 3/6] hid: Allow bus wildcard matching Henrik Rydberg
2012-04-23 10:07 ` [PATCH v3 4/6] hid: Create a generic device group Henrik Rydberg
2012-04-23 21:26 ` Gustavo Padovan
2012-04-23 22:31 ` Henrik Rydberg [this message]
2012-04-23 10:07 ` [PATCH v3 5/6] hid-multitouch: Switch to device groups Henrik Rydberg
2012-04-30 14:58 ` Benjamin Tissoires
2012-04-30 16:42 ` Jiri Kosina
2012-04-30 18:30 ` Henrik Rydberg
2012-04-30 18:51 ` Benjamin Tissoires
2012-05-01 6:35 ` Henrik Rydberg
2012-04-23 10:07 ` [PATCH 6/6] hid: Create a common generic driver Henrik Rydberg
2012-04-23 10:51 ` [PATCH v3 0/6] hid: Introduce device groups Benjamin Tissoires
2012-04-23 15:21 ` Benjamin Tissoires
2012-04-30 8:35 ` Jiri Kosina
2012-04-30 8:44 ` Jiri Kosina
2012-04-30 11:53 ` Henrik Rydberg
2012-04-30 11:55 ` Jiri Kosina
2012-05-01 12:23 ` Jiri Kosina
2012-05-01 11:03 ` Jiri Kosina
2012-05-02 5:46 ` Henrik Rydberg
2012-05-02 8:33 ` Benjamin Tissoires
2012-05-02 8:45 ` Jiri Kosina
2012-05-02 10:55 ` Benjamin Tissoires
2012-05-03 10:06 ` Benjamin Tissoires
2012-05-03 12:23 ` Henrik Rydberg
2012-05-03 12:45 ` Benjamin Tissoires
2012-05-03 13:19 ` Henrik Rydberg
2012-05-03 13:37 ` Benjamin Tissoires
2012-05-03 13:54 ` Henrik Rydberg
2012-05-03 14:04 ` Benjamin Tissoires
2012-05-03 14:16 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423223146.GA6595@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=dmitry.torokhov@gmail.com \
--cc=gustavo@padovan.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).